third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp - Issue 2809733003: Move most of FrameLoader::CheckCompleted() to Document

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp

Issue 2809733003: Move most of FrameLoader::CheckCompleted() to Document (Closed)

Patch Set: processingLoadEvent() as part of shouldComplete(), cleanup shouldComplete() Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp b/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp

index d9f83262d3de730661f27bbaf56581dfd7af9f13..5ebdae9de36672089d00a87ee104e10dc511f784 100644

--- a/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp

+++ b/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp

@@ -483,7 +483,7 @@ void WebRemoteFrameImpl::DidStopLoading() {

if (Parent() && Parent()->IsWebLocalFrame()) {

WebLocalFrameImpl* parent_frame =

ToWebLocalFrameImpl(Parent()->ToWebLocalFrame());

- parent_frame->GetFrame()->Loader().CheckCompleted();

+ parent_frame->GetFrame()->GetDocument()->CheckCompleted();

}