third_party/WebKit/Source/core/dom/DocumentTest.cpp - Issue 2809733003: Move most of FrameLoader::CheckCompleted() to Document

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/DocumentTest.cpp

Issue 2809733003: Move most of FrameLoader::CheckCompleted() to Document (Closed)

Patch Set: Fix failing android test Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/DocumentTest.cpp

diff --git a/third_party/WebKit/Source/core/dom/DocumentTest.cpp b/third_party/WebKit/Source/core/dom/DocumentTest.cpp

index 6002eb4c9a681579c2da9dbe943feeaf2783e9f5..2c8158432782b24c3336bee3c8562bfcbd13061c 100644

--- a/third_party/WebKit/Source/core/dom/DocumentTest.cpp

+++ b/third_party/WebKit/Source/core/dom/DocumentTest.cpp

@@ -727,10 +727,10 @@ TEST_F(DocumentTest, ValidationMessageCleanup) {

MockValidationMessageClient* mock_client = new MockValidationMessageClient();

GetDocument().GetSettings()->SetScriptEnabled(true);

GetPage().SetValidationMessageClient(mock_client);

- // implicitOpen()-implicitClose() makes Document.loadEventFinished()

+ // ImplicitOpen()-CancelParsing() makes Document.loadEventFinished()

// true. It's necessary to kick unload process.

GetDocument().ImplicitOpen(kForceSynchronousParsing);

- GetDocument().ImplicitClose();

+ GetDocument().CancelParsing();

GetDocument().AppendChild(GetDocument().createElement("html"));

SetHtmlInnerHTML("<body><input required></body>");

Element* script = GetDocument().createElement("script");