chrome/android/javatests/src/org/chromium/chrome/browser/infobar/SearchGeolocationDisclosureInfoBarTest.java - Issue 2809733003: Move most of FrameLoader::CheckCompleted() to Document

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/infobar/SearchGeolocationDisclosureInfoBarTest.java

Issue 2809733003: Move most of FrameLoader::CheckCompleted() to Document (Closed)

Patch Set: Fix failing android test Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-reload-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/infobar/SearchGeolocationDisclosureInfoBarTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/infobar/SearchGeolocationDisclosureInfoBarTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/infobar/SearchGeolocationDisclosureInfoBarTest.java

index bb579c2d5b3a8ecc87336901350d0b796ee7355d..88b87d3e749d253b9b203299aa6e05af30a627dd 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/infobar/SearchGeolocationDisclosureInfoBarTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/infobar/SearchGeolocationDisclosureInfoBarTest.java

@@ -21,7 +21,7 @@ import java.util.concurrent.TimeoutException;

/** Tests for the SearchGeolocationDisclosureInfobar. */

public class SearchGeolocationDisclosureInfoBarTest

extends ChromeActivityTestCaseBase<ChromeActivity> {

- private static final String SEARCH_PAGE = "/chrome/test/data/empty.html";

+ private static final String SEARCH_PAGE = "/chrome/test/data/android/google.html";

private static final String ENABLE_NEW_DISCLOSURE_FEATURE =

"enable-features=ConsistentOmniboxGeolocation";

private static final String DISABLE_NEW_DISCLOSURE_FEATURE =