Move a good set of gfx unit tests into gfx_unittests target.

Move a good set of gfx unit tests into gfx_unittests target.

This requires to major changes:

1- It requires the introduction of GfxTestSuite to allow us to
initialize the ResourceBundle which is required for some of these tests
to pass.
2- It requires to split gfx_unittests target out of gfx.gyp, into
gfx_tests.gyp. This is necessary because otherwise a circular dependency
between ui_base.gyp and gfx.gyp would arise.

The circular dependency is the form of:
gfx.gyp -> ui_base.gyp -> gfx.gyp

And is created because gfx_unittests now requires ResourceBundle to link
which is in ui_base target.

BUG=331829
TEST=ui_unittests,gfx_unittests
R=danakj@chromium.org
TBR=ben@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270586

[tfarina, 2014-05-14 03:17:00]

This needs a real review.

ptal.

thanks

[danakj, 2014-05-14 14:16:02]

LGTM

https://codereview.chromium.org/280973003/diff/60001/ui/gfx/test/DEPS
File ui/gfx/test/DEPS (right):

https://codereview.chromium.org/280973003/diff/60001/ui/gfx/test/DEPS#newcode5
ui/gfx/test/DEPS:5: "+ui/gl/gl_surface.h",
this isn't used in the run_all_unittests.cc file. i guess none of these tests
try to use GL? then you can remove this here.

[tfarina, 2014-05-14 17:16:19]

https://codereview.chromium.org/280973003/diff/60001/ui/gfx/test/DEPS
File ui/gfx/test/DEPS (right):

https://codereview.chromium.org/280973003/diff/60001/ui/gfx/test/DEPS#newcode5
ui/gfx/test/DEPS:5: "+ui/gl/gl_surface.h",
On 2014/05/14 14:16:03, danakj wrote:
> this isn't used in the run_all_unittests.cc file. i guess none of these tests
> try to use GL? then you can remove this here.
Good catch. I forgot to remove this when I made the changes for patch set 2.

[tfarina, 2014-05-14 17:17:15]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2014-05-14 17:17:40]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tfarina@chromium.org/280973003/80001

[commit-bot: I haz the power, 2014-05-14 19:03:41]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[commit-bot: I haz the power, 2014-05-14 19:18:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-14 19:18:40]

Try jobs failed on following builders:
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[tfarina, 2014-05-14 19:23:34]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2014-05-14 19:24:16]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tfarina@chromium.org/280973003/80001

[commit-bot: I haz the power, 2014-05-14 19:44:10]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[commit-bot: I haz the power, 2014-05-14 19:58:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-14 19:58:44]

Try jobs failed on following builders:
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[tfarina, 2014-05-14 20:24:59]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2014-05-14 20:26:42]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tfarina@chromium.org/280973003/80001

[commit-bot: I haz the power, 2014-05-14 20:43:49]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[tfarina, 2014-05-14 20:49:50]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2014-05-14 20:50:52]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tfarina@chromium.org/280973003/100001

[commit-bot: I haz the power, 2014-05-15 00:31:24]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-15 00:36:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-15 00:36:37]

Try jobs failed on following builders:
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)

[tfarina, 2014-05-15 00:50:33]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2014-05-15 00:51:36]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tfarina@chromium.org/280973003/100001

[tfarina, 2014-05-15 05:58:15]

Committed patchset #4 manually as r270586 (presubmit successful).

[vabr (Chromium), 2014-05-15 06:34:54]

A revert of this CL has been created in
https://codereview.chromium.org/290453002/ by vabr@chromium.org.

The reason for reverting is: Speculative revert: Compilation appears broken on
http://chromegw.corp.google.com/i/chromium.linux/builders/Linux%20Builder%20%...
after this CL, with libgfx-related errors:

FAILED: /b/build/goma/gomacc c++ -Wl,-z,now -Wl,-z,relro -Wl,--fatal-warnings
-pthread -Wl,-z,noexecstack -fPIC
-B/b/build/slave/Linux_Builder__dbg_/build/src/third_party/binutils/Linux_x64/Release/bin
-Wl,--disable-new-dtags -L. -Wl,-uIsHeapProfilerRunning,-uProfilerStart
-Wl,-u_Z21InitialMallocHook_NewPKvj,-u_Z22InitialMallocHook_MMapPKvS0_jiiix,-u_Z22InitialMallocHook_SbrkPKvi
-Wl,-u_Z21InitialMallocHook_NewPKvm,-u_Z22InitialMallocHook_MMapPKvS0_miiil,-u_Z22InitialMallocHook_SbrkPKvl
-Wl,-u_ZN15HeapLeakChecker12IgnoreObjectEPKv,-u_ZN15HeapLeakChecker14UnIgnoreObjectEPKv
-m64 -Wl,--icf=none -Wl,-rpath=\$ORIGIN/lib/ -Wl,-rpath-link=lib/ -o
gfx_unittests -Wl,--start-group obj/ui/gfx/gfx_unittests.font_unittest.o
obj/ui/gfx/image/gfx_unittests.image_family_unittest.o
obj/ui/gfx/image/gfx_unittests.image_skia_unittest.o
obj/ui/gfx/image/gfx_unittests.image_unittest.o
obj/ui/gfx/image/gfx_unittests.image_unittest_util.o
obj/ui/gfx/test/gfx_unittests.run_all_unittests.o
obj/ui/gfx/gfx_unittests.text_elider_unittest.o
obj/ui/gfx/gfx_unittests.text_utils_unittest.o
obj/ui/gfx/animation/gfx_unittests.animation_container_unittest.o
obj/ui/gfx/animation/gfx_unittests.animation_unittest.o
obj/ui/gfx/animation/gfx_unittests.multi_animation_unittest.o
obj/ui/gfx/animation/gfx_unittests.slide_animation_unittest.o
obj/ui/gfx/animation/gfx_unittests.tween_unittest.o
obj/ui/gfx/gfx_unittests.blit_unittest.o
obj/ui/gfx/gfx_unittests.break_list_unittest.o
obj/ui/gfx/codec/gfx_unittests.jpeg_codec_unittest.o
obj/ui/gfx/codec/gfx_unittests.png_codec_unittest.o
obj/ui/gfx/gfx_unittests.color_analysis_unittest.o
obj/ui/gfx/gfx_unittests.color_utils_unittest.o
obj/ui/gfx/gfx_unittests.display_unittest.o
obj/ui/gfx/geometry/gfx_unittests.box_unittest.o
obj/ui/gfx/geometry/gfx_unittests.cubic_bezier_unittest.o
obj/ui/gfx/geometry/gfx_unittests.insets_unittest.o
obj/ui/gfx/geometry/gfx_unittests.matrix3_unittest.o
obj/ui/gfx/geometry/gfx_unittests.point_unittest.o
obj/ui/gfx/geometry/gfx_unittests.point3_unittest.o
obj/ui/gfx/geometry/gfx_unittests.quad_unittest.o
obj/ui/gfx/geometry/gfx_unittests.r_tree_unittest.o
obj/ui/gfx/geometry/gfx_unittests.rect_unittest.o
obj/ui/gfx/geometry/gfx_unittests.safe_integer_conversions_unittest.o
obj/ui/gfx/geometry/gfx_unittests.size_unittest.o
obj/ui/gfx/geometry/gfx_unittests.vector2d_unittest.o
obj/ui/gfx/geometry/gfx_unittests.vector3d_unittest.o
obj/ui/gfx/image/gfx_unittests.image_util_unittest.o
obj/ui/gfx/range/gfx_unittests.range_unittest.o
obj/ui/gfx/gfx_unittests.sequential_id_generator_unittest.o
obj/ui/gfx/gfx_unittests.shadow_value_unittest.o
obj/ui/gfx/gfx_unittests.skbitmap_operations_unittest.o
obj/ui/gfx/gfx_unittests.skrect_conversion_unittest.o
obj/ui/gfx/gfx_unittests.transform_util_unittest.o
obj/ui/gfx/gfx_unittests.utf16_indexing_unittest.o
obj/ui/gfx/gfx_unittests.transform_unittest.o
obj/ui/gfx/gfx_unittests.interpolated_transform_unittest.o
obj/ui/gfx/gfx_unittests.platform_font_pango_unittest.o
obj/base/libtest_support_base.a obj/testing/libgtest.a
obj/third_party/libpng/libpng.a obj/ui/gfx/libgfx_test_support.a
obj/base/allocator/liballocator.a obj/base/libbase_static.a
obj/testing/libgmock.a obj/third_party/libxml/libxml2.a
obj/third_party/zlib/libchrome_zlib.a
obj/base/third_party/dynamic_annotations/libdynamic_annotations.a
lib/libui_base.so lib/libgfx.so lib/libicuuc.so lib/libskia.so lib/libbase.so
lib/libgfx_geometry.so lib/libbase_i18n.so -Wl,--end-group -lrt -ldl
-lfontconfig -lpangocairo-1.0 -lcairo -lpangoft2-1.0 -lpango-1.0 -lfreetype
-lgobject-2.0 -lglib-2.0
lib/libgfx.so:error: undefined reference to 'XCreateRegion'
lib/libgfx.so:error: undefined reference to 'XUnionRectWithRegion'
lib/libgfx.so:error: undefined reference to 'XPolygonRegion'
collect2: ld returned 1 exit status.

[tfarina, 2014-05-15 06:51:31]

On Thu, May 15, 2014 at 3:34 AM, <vabr@chromium.org> wrote:

> A revert of this CL has been created in
> https://codereview.chromium.org/290453002/ by vabr@chromium.org.
>
> The reason for reverting is: Speculative revert: Compilation appears
> broken on
> http://chromegw.corp.google.com/i/chromium.linux/builders/
> Linux%20Builder%20%28dbg%29
> after this CL, with libgfx-related errors:
>
> FAILED: /b/build/goma/gomacc c++ -Wl,-z,now -Wl,-z,relro
> -Wl,--fatal-warnings
> -pthread -Wl,-z,noexecstack -fPIC
> -B/b/build/slave/Linux_Builder__dbg_/build/src/third_
> party/binutils/Linux_x64/Release/bin
> -Wl,--disable-new-dtags -L. -Wl,-uIsHeapProfilerRunning,-uProfilerStart
> -Wl,-u_Z21InitialMallocHook_NewPKvj,-u_Z22InitialMallocHook_
> MMapPKvS0_jiiix,-u_Z22InitialMallocHook_SbrkPKvi
> -Wl,-u_Z21InitialMallocHook_NewPKvm,-u_Z22InitialMallocHook_
> MMapPKvS0_miiil,-u_Z22InitialMallocHook_SbrkPKvl
> -Wl,-u_ZN15HeapLeakChecker12IgnoreObjectEPKv,-u_
> ZN15HeapLeakChecker14UnIgnoreObjectEPKv
> -m64 -Wl,--icf=none -Wl,-rpath=\$ORIGIN/lib/ -Wl,-rpath-link=lib/ -o
> gfx_unittests -Wl,--start-group obj/ui/gfx/gfx_unittests.font_unittest.o
> obj/ui/gfx/image/gfx_unittests.image_family_unittest.o
> obj/ui/gfx/image/gfx_unittests.image_skia_unittest.o
> obj/ui/gfx/image/gfx_unittests.image_unittest.o
> obj/ui/gfx/image/gfx_unittests.image_unittest_util.o
> obj/ui/gfx/test/gfx_unittests.run_all_unittests.o
> obj/ui/gfx/gfx_unittests.text_elider_unittest.o
> obj/ui/gfx/gfx_unittests.text_utils_unittest.o
> obj/ui/gfx/animation/gfx_unittests.animation_container_unittest.o
> obj/ui/gfx/animation/gfx_unittests.animation_unittest.o
> obj/ui/gfx/animation/gfx_unittests.multi_animation_unittest.o
> obj/ui/gfx/animation/gfx_unittests.slide_animation_unittest.o
> obj/ui/gfx/animation/gfx_unittests.tween_unittest.o
> obj/ui/gfx/gfx_unittests.blit_unittest.o
> obj/ui/gfx/gfx_unittests.break_list_unittest.o
> obj/ui/gfx/codec/gfx_unittests.jpeg_codec_unittest.o
> obj/ui/gfx/codec/gfx_unittests.png_codec_unittest.o
> obj/ui/gfx/gfx_unittests.color_analysis_unittest.o
> obj/ui/gfx/gfx_unittests.color_utils_unittest.o
> obj/ui/gfx/gfx_unittests.display_unittest.o
> obj/ui/gfx/geometry/gfx_unittests.box_unittest.o
> obj/ui/gfx/geometry/gfx_unittests.cubic_bezier_unittest.o
> obj/ui/gfx/geometry/gfx_unittests.insets_unittest.o
> obj/ui/gfx/geometry/gfx_unittests.matrix3_unittest.o
> obj/ui/gfx/geometry/gfx_unittests.point_unittest.o
> obj/ui/gfx/geometry/gfx_unittests.point3_unittest.o
> obj/ui/gfx/geometry/gfx_unittests.quad_unittest.o
> obj/ui/gfx/geometry/gfx_unittests.r_tree_unittest.o
> obj/ui/gfx/geometry/gfx_unittests.rect_unittest.o
> obj/ui/gfx/geometry/gfx_unittests.safe_integer_conversions_unittest.o
> obj/ui/gfx/geometry/gfx_unittests.size_unittest.o
> obj/ui/gfx/geometry/gfx_unittests.vector2d_unittest.o
> obj/ui/gfx/geometry/gfx_unittests.vector3d_unittest.o
> obj/ui/gfx/image/gfx_unittests.image_util_unittest.o
> obj/ui/gfx/range/gfx_unittests.range_unittest.o
> obj/ui/gfx/gfx_unittests.sequential_id_generator_unittest.o
> obj/ui/gfx/gfx_unittests.shadow_value_unittest.o
> obj/ui/gfx/gfx_unittests.skbitmap_operations_unittest.o
> obj/ui/gfx/gfx_unittests.skrect_conversion_unittest.o
> obj/ui/gfx/gfx_unittests.transform_util_unittest.o
> obj/ui/gfx/gfx_unittests.utf16_indexing_unittest.o
> obj/ui/gfx/gfx_unittests.transform_unittest.o
> obj/ui/gfx/gfx_unittests.interpolated_transform_unittest.o
> obj/ui/gfx/gfx_unittests.platform_font_pango_unittest.o
> obj/base/libtest_support_base.a obj/testing/libgtest.a
> obj/third_party/libpng/libpng.a obj/ui/gfx/libgfx_test_support.a
> obj/base/allocator/liballocator.a obj/base/libbase_static.a
> obj/testing/libgmock.a obj/third_party/libxml/libxml2.a
> obj/third_party/zlib/libchrome_zlib.a
> obj/base/third_party/dynamic_annotations/libdynamic_annotations.a
> lib/libui_base.so lib/libgfx.so lib/libicuuc.so lib/libskia.so
> lib/libbase.so
> lib/libgfx_geometry.so lib/libbase_i18n.so

here we need libgfx_11.so. Where is it?


> -Wl,--end-group -lrt -ldl
> -lfontconfig -lpangocairo-1.0 -lcairo -lpangoft2-1.0 -lpango-1.0 -lfreetype
> -lgobject-2.0 -lglib-2.0
> lib/libgfx.so:error: undefined reference to 'XCreateRegion'
> lib/libgfx.so:error: undefined reference to 'XUnionRectWithRegion'
> lib/libgfx.so:error: undefined reference to 'XPolygonRegion'
> collect2: ld returned 1 exit status.
>
> Those functions are only called in path_x11.cc.

I don't know yet how my patch broke that. I need some sleep.

Sadrul, could you help me here?


> https://codereview.chromium.org/280973003/
>



-- 
Thiago Farina

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.