Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2809723002: Let QUIC_VERSION_38 support IETF PADDING frame (1 byte frame with type 0x00) and respect NSTP conne… (Closed)

Created:
3 years, 8 months ago by danzh1
Modified:
3 years, 8 months ago
Reviewers:
Jana
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Let QUIC_VERSION_38 support IETF PADDING frame (1 byte frame with type 0x00) and respect NSTP connection option. Protected by FLAGS_quic_reloadable_flag_quic_enable_version_38. Merge internal change: 152158483 R=jri@chromium.org BUG=

Patch Set 1 #

Patch Set 2 : Remove old FLAGS_quic_enable_version_38 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+273 lines, -17 lines) Patch
M net/quic/core/quic_connection.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/quic_data_reader.h View 1 chunk +6 lines, -0 lines 0 comments Download
M net/quic/core/quic_data_reader.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M net/quic/core/quic_data_writer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/core/quic_data_writer.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/core/quic_flags_list.h View 1 2 chunks +4 lines, -3 lines 0 comments Download
M net/quic/core/quic_framer.h View 2 chunks +3 lines, -0 lines 0 comments Download
M net/quic/core/quic_framer.cc View 4 chunks +46 lines, -4 lines 0 comments Download
M net/quic/core/quic_framer_test.cc View 6 chunks +187 lines, -0 lines 0 comments Download
M net/quic/core/quic_version_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_version_manager.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/quic_version_manager_test.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/core/quic_versions.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/core/quic_versions.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_dispatcher_test.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 2810643004 Patch 1

Dependent Patchsets:

Issue 2809773002 Patch 1

Messages

Total messages: 6 (4 generated)
danzh1
3 years, 8 months ago (2017-04-10 17:19:16 UTC) #1
Jana
3 years, 8 months ago (2017-04-10 19:18:18 UTC) #6 
lgtm

Powered by Google App Engine
This is Rietveld 408576698