Fix double close in MojoAudioOutputStream.

media/mojo/services/mojo_audio_output_stream.cc

Index: media/mojo/services/mojo_audio_output_stream.cc
diff --git a/media/mojo/services/mojo_audio_output_stream.cc b/media/mojo/services/mojo_audio_output_stream.cc
index 1be3171295cd7ef8c92b82afaf84dbbd656be57d..69e696901b35368b625332cfd76d1ec418da5978 100644
--- a/media/mojo/services/mojo_audio_output_stream.cc
+++ b/media/mojo/services/mojo_audio_output_stream.cc
@@ -71,7 +71,7 @@ void MojoAudioOutputStream::OnStreamCreated(
   mojo::ScopedSharedBufferHandle buffer_handle = mojo::WrapSharedMemoryHandle(
       foreign_memory_handle, shared_memory->requested_size(), false);
   mojo::ScopedHandle socket_handle =
-      mojo::WrapPlatformFile(foreign_socket->handle());
+      mojo::WrapPlatformFile(foreign_socket->Release());

[Nico, 2017/04/10 15:29:35]

Should WrapPltformFile take an rvalue of some kind to make this kind of mistake
impossible through static typing?

[Max Morin, 2017/04/10 15:44:20]

It should probably take a ScopedPlatformHandle (and manually closed handles
shouldn't be used ever). I think this would be a lot of work to change though.

[Nico, 2017/04/10 15:50:37]

Maybe at least file a bug.

[Max Morin, 2017/04/11 09:11:11]

I filed crbug.com/710376 and also added checks for double-closing to the unit
tests.

 
   DCHECK(buffer_handle.is_valid());
   DCHECK(socket_handle.is_valid());