Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Side by Side Diff: media/audio/audio_output_delegate.h

Issue 2809673002: Fix double close in MojoAudioOutputStream. (Closed)
Patch Set: Fix Win complie. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MEDIA_AUDIO_AUDIO_OUTPUT_DELEGATE_H_ 5 #ifndef MEDIA_AUDIO_AUDIO_OUTPUT_DELEGATE_H_
6 #define MEDIA_AUDIO_AUDIO_OUTPUT_DELEGATE_H_ 6 #define MEDIA_AUDIO_AUDIO_OUTPUT_DELEGATE_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <string> 9 #include <string>
10 10
(...skipping 14 matching lines...) Expand all
25 public: 25 public:
26 // An AudioOutputDelegate must not call back to its EventHandler in its 26 // An AudioOutputDelegate must not call back to its EventHandler in its
27 // constructor. 27 // constructor.
28 class MEDIA_EXPORT EventHandler { 28 class MEDIA_EXPORT EventHandler {
29 public: 29 public:
30 EventHandler(); 30 EventHandler();
31 virtual ~EventHandler(); 31 virtual ~EventHandler();
32 32
33 // Called when construction is finished and the stream is ready for 33 // Called when construction is finished and the stream is ready for
34 // playout. 34 // playout.
35 virtual void OnStreamCreated(int stream_id, 35 virtual void OnStreamCreated(
36 base::SharedMemory* shared_memory, 36 int stream_id,
37 base::CancelableSyncSocket* socket) = 0; 37 base::SharedMemory* shared_memory,
38 std::unique_ptr<base::CancelableSyncSocket> socket) = 0;
38 39
39 // Called if stream encounters an error and has become unusable. 40 // Called if stream encounters an error and has become unusable.
40 virtual void OnStreamError(int stream_id) = 0; 41 virtual void OnStreamError(int stream_id) = 0;
41 }; 42 };
42 43
43 AudioOutputDelegate(); 44 AudioOutputDelegate();
44 virtual ~AudioOutputDelegate(); 45 virtual ~AudioOutputDelegate();
45 46
46 // TODO(maxmorin): Remove GetController() when crbug.com/647185 is closed. 47 // TODO(maxmorin): Remove GetController() when crbug.com/647185 is closed.
47 // This function is used to provide control of the audio stream to 48 // This function is used to provide control of the audio stream to
48 // WebrtcAudioPrivateGetActiveSinkFunction and others in the webrtc extension 49 // WebrtcAudioPrivateGetActiveSinkFunction and others in the webrtc extension
49 // API. Since the controller is shared, this means that it might outlive the 50 // API. Since the controller is shared, this means that it might outlive the
50 // AudioOutputDelegate. In this case, it is still safe to call functions on 51 // AudioOutputDelegate. In this case, it is still safe to call functions on
51 // the controller, but it will not do anything. The controller is also shared 52 // the controller, but it will not do anything. The controller is also shared
52 // with AudioStreamMonitor. 53 // with AudioStreamMonitor.
53 virtual scoped_refptr<AudioOutputController> GetController() const = 0; 54 virtual scoped_refptr<AudioOutputController> GetController() const = 0;
54 virtual int GetStreamId() const = 0; 55 virtual int GetStreamId() const = 0;
55 56
56 // Stream control: 57 // Stream control:
57 virtual void OnPlayStream() = 0; 58 virtual void OnPlayStream() = 0;
58 virtual void OnPauseStream() = 0; 59 virtual void OnPauseStream() = 0;
59 virtual void OnSetVolume(double volume) = 0; 60 virtual void OnSetVolume(double volume) = 0;
60 }; 61 };
61 62
62 } // namespace media 63 } // namespace media
63 64
64 #endif // MEDIA_AUDIO_AUDIO_OUTPUT_DELEGATE_H_ 65 #endif // MEDIA_AUDIO_AUDIO_OUTPUT_DELEGATE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698