Fix double close in MojoAudioOutputStream.

content/browser/renderer_host/media/audio_output_delegate_impl_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/media/audio_output_delegate_impl.h"
 
 #include <stdint.h>
 
 #include <memory>
 #include <utility>
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/memory/ptr_util.h"
 #include "base/message_loop/message_loop.h"
 #include "base/run_loop.h"
+#include "base/sync_socket.h"
 #include "content/browser/audio_manager_thread.h"
 #include "content/browser/media/capture/audio_mirroring_manager.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/media_observer.h"
 #include "content/public/test/test_browser_thread_bundle.h"
 #include "media/audio/audio_output_controller.h"
 #include "media/audio/fake_audio_log_factory.h"
 #include "media/audio/fake_audio_manager.h"
 #include "media/base/media_switches.h"
 #include "testing/gmock/include/gmock/gmock.h"
@@ skipping 37 matching lines @@
                                  int page_request_id,
                                  MediaStreamType stream_type,
                                  bool is_secure) override {}
 
   MOCK_METHOD2(OnCreatingAudioStream,
                void(int render_process_id, int render_frame_id));
 };
 
 class MockEventHandler : public media::AudioOutputDelegate::EventHandler {
  public:
-  MOCK_METHOD3(OnStreamCreated,
-               void(int stream_id,
-                    base::SharedMemory* shared_memory,
-                    base::CancelableSyncSocket* socket));
+  void OnStreamCreated(int stream_id,
+                       base::SharedMemory* shared_memory,
+                       std::unique_ptr<base::CancelableSyncSocket> socket) {
+    EXPECT_EQ(stream_id, kStreamId);
+    EXPECT_NE(shared_memory, nullptr);
+    EXPECT_NE(socket.get(), nullptr);
+    GotOnStreamCreated();
+  }
+
+  MOCK_METHOD0(GotOnStreamCreated, void());
   MOCK_METHOD1(OnStreamError, void(int stream_id));
 };
 
 class DummyAudioOutputStream : public media::AudioOutputStream {
  public:
   // AudioOutputSteam implementation:
   bool Open() override { return true; }
   void Start(AudioSourceCallback* cb) override {}
   void Stop() override {}
   void SetVolume(double volume) override {}
@@ skipping 19 matching lines @@
 
     audio_manager_.reset(new media::FakeAudioManager(
         audio_thread_->task_runner(), audio_thread_->worker_task_runner(),
         &log_factory_));
   }
 
   // Test bodies are here, so that we can run them on the IO thread.
   void CreateTest(base::Closure done) {
     EXPECT_CALL(media_observer_,
                 OnCreatingAudioStream(kRenderProcessId, kRenderFrameId));
-    EXPECT_CALL(event_handler_,
-                OnStreamCreated(kStreamId, NotNull(), NotNull()));
+    EXPECT_CALL(event_handler_, GotOnStreamCreated());
     EXPECT_CALL(mirroring_manager_,
                 AddDiverter(kRenderProcessId, kRenderFrameId, NotNull()));
 
     {
       AudioOutputDelegateImpl delegate(
           &event_handler_, audio_manager_.get(),
           log_factory_.CreateAudioLog(
               media::AudioLogFactory::AUDIO_OUTPUT_CONTROLLER),
           &mirroring_manager_, &media_observer_, kStreamId, kRenderFrameId,
           kRenderProcessId, media::AudioParameters::UnavailableDeviceParams(),
           kDefaultDeviceId);
 
       SyncWithAllThreads();
 
       EXPECT_CALL(mirroring_manager_, RemoveDiverter(NotNull()));
     }
     SyncWithAllThreads();
     BrowserThread::PostTask(BrowserThread::UI, FROM_HERE, done);
   }
 
   void PlayTest(base::Closure done) {
     EXPECT_CALL(media_observer_,
                 OnCreatingAudioStream(kRenderProcessId, kRenderFrameId));
-    EXPECT_CALL(event_handler_,
-                OnStreamCreated(kStreamId, NotNull(), NotNull()));
+    EXPECT_CALL(event_handler_, GotOnStreamCreated());
     EXPECT_CALL(mirroring_manager_,
                 AddDiverter(kRenderProcessId, kRenderFrameId, NotNull()));
 
     {
       AudioOutputDelegateImpl delegate(
           &event_handler_, audio_manager_.get(),
           log_factory_.CreateAudioLog(
               media::AudioLogFactory::AUDIO_OUTPUT_CONTROLLER),
           &mirroring_manager_, &media_observer_, kStreamId, kRenderFrameId,
           kRenderProcessId, media::AudioParameters::UnavailableDeviceParams(),
           kDefaultDeviceId);
 
       delegate.OnPlayStream();
 
       SyncWithAllThreads();
 
       EXPECT_CALL(mirroring_manager_, RemoveDiverter(NotNull()));
     }
     SyncWithAllThreads();
     BrowserThread::PostTask(BrowserThread::UI, FROM_HERE, done);
   }
 
   void PauseTest(base::Closure done) {
     EXPECT_CALL(media_observer_,
                 OnCreatingAudioStream(kRenderProcessId, kRenderFrameId));
-    EXPECT_CALL(event_handler_,
-                OnStreamCreated(kStreamId, NotNull(), NotNull()));
+    EXPECT_CALL(event_handler_, GotOnStreamCreated());
     EXPECT_CALL(mirroring_manager_,
                 AddDiverter(kRenderProcessId, kRenderFrameId, NotNull()));
 
     {
       AudioOutputDelegateImpl delegate(
           &event_handler_, audio_manager_.get(),
           log_factory_.CreateAudioLog(
               media::AudioLogFactory::AUDIO_OUTPUT_CONTROLLER),
           &mirroring_manager_, &media_observer_, kStreamId, kRenderFrameId,
           kRenderProcessId, media::AudioParameters::UnavailableDeviceParams(),
           kDefaultDeviceId);
 
       delegate.OnPauseStream();
 
       SyncWithAllThreads();
 
       EXPECT_CALL(mirroring_manager_, RemoveDiverter(NotNull()));
     }
     SyncWithAllThreads();
     BrowserThread::PostTask(BrowserThread::UI, FROM_HERE, done);
   }
 
   void PlayPausePlayTest(base::Closure done) {
     EXPECT_CALL(media_observer_,
                 OnCreatingAudioStream(kRenderProcessId, kRenderFrameId));
-    EXPECT_CALL(event_handler_,
-                OnStreamCreated(kStreamId, NotNull(), NotNull()));
+    EXPECT_CALL(event_handler_, GotOnStreamCreated());
     EXPECT_CALL(mirroring_manager_,
                 AddDiverter(kRenderProcessId, kRenderFrameId, NotNull()));
 
     {
       AudioOutputDelegateImpl delegate(
           &event_handler_, audio_manager_.get(),
           log_factory_.CreateAudioLog(
               media::AudioLogFactory::AUDIO_OUTPUT_CONTROLLER),
           &mirroring_manager_, &media_observer_, kStreamId, kRenderFrameId,
           kRenderProcessId, media::AudioParameters::UnavailableDeviceParams(),
           kDefaultDeviceId);
 
       delegate.OnPlayStream();
       delegate.OnPauseStream();
       delegate.OnPlayStream();
 
       SyncWithAllThreads();
 
       EXPECT_CALL(mirroring_manager_, RemoveDiverter(NotNull()));
     }
     SyncWithAllThreads();
     BrowserThread::PostTask(BrowserThread::UI, FROM_HERE, done);
   }
 
   void PlayPlayTest(base::Closure done) {
     EXPECT_CALL(media_observer_,
                 OnCreatingAudioStream(kRenderProcessId, kRenderFrameId));
-    EXPECT_CALL(event_handler_,
-                OnStreamCreated(kStreamId, NotNull(), NotNull()));
+    EXPECT_CALL(event_handler_, GotOnStreamCreated());
     EXPECT_CALL(mirroring_manager_,
                 AddDiverter(kRenderProcessId, kRenderFrameId, NotNull()));
 
     {
       AudioOutputDelegateImpl delegate(
           &event_handler_, audio_manager_.get(),
           log_factory_.CreateAudioLog(
               media::AudioLogFactory::AUDIO_OUTPUT_CONTROLLER),
           &mirroring_manager_, &media_observer_, kStreamId, kRenderFrameId,
           kRenderProcessId, media::AudioParameters::UnavailableDeviceParams(),
           kDefaultDeviceId);
 
       delegate.OnPlayStream();
       delegate.OnPlayStream();
 
       SyncWithAllThreads();
 
       EXPECT_CALL(mirroring_manager_, RemoveDiverter(NotNull()));
     }
     SyncWithAllThreads();
     BrowserThread::PostTask(BrowserThread::UI, FROM_HERE, done);
   }
 
   void CreateDivertTest(base::Closure done) {
     EXPECT_CALL(media_observer_,
                 OnCreatingAudioStream(kRenderProcessId, kRenderFrameId));
-    EXPECT_CALL(event_handler_,
-                OnStreamCreated(kStreamId, NotNull(), NotNull()));
+    EXPECT_CALL(event_handler_, GotOnStreamCreated());
     EXPECT_CALL(mirroring_manager_,
                 AddDiverter(kRenderProcessId, kRenderFrameId, NotNull()));
 
     DummyAudioOutputStream stream;
     {
       AudioOutputDelegateImpl delegate(
           &event_handler_, audio_manager_.get(),
           log_factory_.CreateAudioLog(
               media::AudioLogFactory::AUDIO_OUTPUT_CONTROLLER),
           &mirroring_manager_, &media_observer_, kStreamId, kRenderFrameId,
           kRenderProcessId, media::AudioParameters::UnavailableDeviceParams(),
           kDefaultDeviceId);
 
       delegate.GetController()->StartDiverting(&stream);
 
       SyncWithAllThreads();
 
       EXPECT_CALL(mirroring_manager_, RemoveDiverter(NotNull()));
     }
     SyncWithAllThreads();
     BrowserThread::PostTask(BrowserThread::UI, FROM_HERE, done);
   }
 
   void CreateDivertPauseTest(base::Closure done) {
     EXPECT_CALL(media_observer_,
                 OnCreatingAudioStream(kRenderProcessId, kRenderFrameId));
-    EXPECT_CALL(event_handler_,
-                OnStreamCreated(kStreamId, NotNull(), NotNull()));
+    EXPECT_CALL(event_handler_, GotOnStreamCreated());
     EXPECT_CALL(mirroring_manager_,
                 AddDiverter(kRenderProcessId, kRenderFrameId, NotNull()));
 
     DummyAudioOutputStream stream;
     {
       AudioOutputDelegateImpl delegate(
           &event_handler_, audio_manager_.get(),
           log_factory_.CreateAudioLog(
               media::AudioLogFactory::AUDIO_OUTPUT_CONTROLLER),
           &mirroring_manager_, &media_observer_, kStreamId, kRenderFrameId,
           kRenderProcessId, media::AudioParameters::UnavailableDeviceParams(),
           kDefaultDeviceId);
 
       delegate.GetController()->StartDiverting(&stream);
 
       SyncWithAllThreads();
       delegate.OnPauseStream();
 
       SyncWithAllThreads();
 
       EXPECT_CALL(mirroring_manager_, RemoveDiverter(NotNull()));
     }
     SyncWithAllThreads();
     BrowserThread::PostTask(BrowserThread::UI, FROM_HERE, done);
   }
 
   void PlayDivertTest(base::Closure done) {
     EXPECT_CALL(media_observer_,
                 OnCreatingAudioStream(kRenderProcessId, kRenderFrameId));
-    EXPECT_CALL(event_handler_,
-                OnStreamCreated(kStreamId, NotNull(), NotNull()));
+    EXPECT_CALL(event_handler_, GotOnStreamCreated());
     EXPECT_CALL(mirroring_manager_,
                 AddDiverter(kRenderProcessId, kRenderFrameId, NotNull()));
 
     DummyAudioOutputStream stream;
     {
       AudioOutputDelegateImpl delegate(
           &event_handler_, audio_manager_.get(),
           log_factory_.CreateAudioLog(
               media::AudioLogFactory::AUDIO_OUTPUT_CONTROLLER),
           &mirroring_manager_, &media_observer_, kStreamId, kRenderFrameId,
           kRenderProcessId, media::AudioParameters::UnavailableDeviceParams(),
           kDefaultDeviceId);
 
       delegate.OnPlayStream();
       delegate.GetController()->StartDiverting(&stream);
 
       SyncWithAllThreads();
 
       EXPECT_CALL(mirroring_manager_, RemoveDiverter(NotNull()));
     }
     SyncWithAllThreads();
     BrowserThread::PostTask(BrowserThread::UI, FROM_HERE, done);
   }
 
   void ErrorTest(base::Closure done) {
     EXPECT_CALL(media_observer_,
                 OnCreatingAudioStream(kRenderProcessId, kRenderFrameId));
-    EXPECT_CALL(event_handler_,
-                OnStreamCreated(kStreamId, NotNull(), NotNull()));
+    EXPECT_CALL(event_handler_, GotOnStreamCreated());
     EXPECT_CALL(event_handler_, OnStreamError(kStreamId));
     EXPECT_CALL(mirroring_manager_,
                 AddDiverter(kRenderProcessId, kRenderFrameId, NotNull()));
 
     {
       AudioOutputDelegateImpl delegate(
           &event_handler_, audio_manager_.get(),
           log_factory_.CreateAudioLog(
               media::AudioLogFactory::AUDIO_OUTPUT_CONTROLLER),
           &mirroring_manager_, &media_observer_, kStreamId, kRenderFrameId,
@@ skipping 26 matching lines @@
           kRenderProcessId, media::AudioParameters::UnavailableDeviceParams(),
           kDefaultDeviceId);
     }
     SyncWithAllThreads();
     BrowserThread::PostTask(BrowserThread::UI, FROM_HERE, done);
   }
 
   void PlayAndDestroyTest(base::Closure done) {
     EXPECT_CALL(media_observer_,
                 OnCreatingAudioStream(kRenderProcessId, kRenderFrameId));
-    EXPECT_CALL(event_handler_,
-                OnStreamCreated(kStreamId, NotNull(), NotNull()));
+    EXPECT_CALL(event_handler_, GotOnStreamCreated());
     EXPECT_CALL(mirroring_manager_,
                 AddDiverter(kRenderProcessId, kRenderFrameId, NotNull()));
     EXPECT_CALL(mirroring_manager_, RemoveDiverter(NotNull()));
 
     {
       AudioOutputDelegateImpl delegate(
           &event_handler_, audio_manager_.get(),
           log_factory_.CreateAudioLog(
               media::AudioLogFactory::AUDIO_OUTPUT_CONTROLLER),
           &mirroring_manager_, &media_observer_, kStreamId, kRenderFrameId,
           kRenderProcessId, media::AudioParameters::UnavailableDeviceParams(),
           kDefaultDeviceId);
 
       SyncWithAllThreads();
 
       delegate.OnPlayStream();
     }
     SyncWithAllThreads();
     BrowserThread::PostTask(BrowserThread::UI, FROM_HERE, done);
   }
 
   void ErrorAndDestroyTest(base::Closure done) {
     EXPECT_CALL(media_observer_,
                 OnCreatingAudioStream(kRenderProcessId, kRenderFrameId));
-    EXPECT_CALL(event_handler_,
-                OnStreamCreated(kStreamId, NotNull(), NotNull()));
+    EXPECT_CALL(event_handler_, GotOnStreamCreated());
     EXPECT_CALL(mirroring_manager_,
                 AddDiverter(kRenderProcessId, kRenderFrameId, NotNull()));
     EXPECT_CALL(mirroring_manager_, RemoveDiverter(NotNull()));
 
     {
       AudioOutputDelegateImpl delegate(
           &event_handler_, audio_manager_.get(),
           log_factory_.CreateAudioLog(
               media::AudioLogFactory::AUDIO_OUTPUT_CONTROLLER),
           &mirroring_manager_, &media_observer_, kStreamId, kRenderFrameId,
@@ skipping 131 matching lines @@
 TEST_F(AudioOutputDelegateTest, ErrorAndDestroy) {
   base::RunLoop l;
   BrowserThread::PostTask(
       BrowserThread::IO, FROM_HERE,
       base::Bind(&AudioOutputDelegateTest::PlayAndDestroyTest,
                  base::Unretained(this), l.QuitClosure()));
   l.Run();
 }
 
 }  // namespace content