Chromium Code Reviews

Unified Diff: BUILD.gn

Issue 2809653003: Introduce mkgrokdump to update tools/v8heapconst.py. (Closed)
Patch Set: address comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
« no previous file with comments | « no previous file | Makefile » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 8daba55e4d6847575df44f16e2387819a3926b88..963e90f267007cc56198417665461daf8c9f5418 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -142,6 +142,7 @@ if (v8_enable_v8_checks == "") {
is_target_simulator = target_cpu != v8_target_cpu
v8_generated_peephole_source = "$target_gen_dir/bytecode-peephole-table.cc"
+v8_generated_heap_constants = "$target_gen_dir/v8heapconst.py"
Michael Achenbach 2017/04/11 10:56:17 Who's reading this?
Yang 2017/04/12 10:32:38 Removed. I had a run_mkgrokdump target at some poi
v8_random_seed = "314159265"
v8_toolset_for_shell = "host"
@@ -2666,6 +2667,28 @@ v8_executable("mkpeephole") {
]
}
+v8_executable("mkgrokdump") {
+ # mkgrokdump is used to create tools/v8heapconst.py.
+ visibility = [ ":*" ] # Only targets in this file can depend on this.
+
+ sources = [
+ "tools/mkgrokdump.cc",
+ ]
+
+ configs = [
+ ":external_config",
+ ":internal_config",
+ ]
+
+ deps = [
+ ":v8",
+ ":v8_libbase",
+ ":v8_libplatform",
+ "//build/config/sanitizers:deps",
+ "//build/win:default_exe_manifest",
+ ]
+}
+
###############################################################################
# Public targets
#
@@ -2681,6 +2704,7 @@ group("gn_all") {
deps = [
":d8",
+ ":mkgrokdump",
":v8_fuzzers",
":v8_hello_world",
":v8_parser_shell",
« no previous file with comments | « no previous file | Makefile » ('j') | no next file with comments »

Powered by Google App Engine