Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Issue 280963002: Move FileHandlersInfo to /extensions and remove struct FileHandlersInfo (Closed)

Created:
6 years, 7 months ago by Devlin
Modified:
6 years, 7 months ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Move FileHandlersInfo to /extensions and remove struct FileHandlersInfo Move FileHandlersParser to /extensions. FileHandlersInfo was a struct which only contained a vector of FileHandlers. Instead, typedef a vector of FileHandlers as a FileHandlersInfo. BUG=374980 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271750

Patch Set 1 : #

Patch Set 2 : Latest master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -391 lines) Patch
M chrome/browser/extensions/api/file_handlers/app_file_handler_util.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/file_handlers/app_file_handler_util.cc View 3 chunks +6 lines, -8 lines 0 comments Download
M chrome/browser/web_applications/web_app.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/web_applications/web_app.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/web_applications/web_app_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/web_applications/web_app_mac.mm View 1 chunk +4 lines, -6 lines 0 comments Download
M chrome/browser/web_applications/web_app_mac_unittest.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome_common.gypi View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 chunks +1 line, -1 line 0 comments Download
D chrome/common/extensions/api/file_handlers/file_handlers_manifest_unittest.cc View 1 chunk +0 lines, -79 lines 0 comments Download
D chrome/common/extensions/api/file_handlers/file_handlers_parser.h View 1 chunk +0 lines, -44 lines 0 comments Download
D chrome/common/extensions/api/file_handlers/file_handlers_parser.cc View 1 chunk +0 lines, -155 lines 0 comments Download
M chrome/common/extensions/chrome_manifest_handlers.cc View 2 chunks +0 lines, -2 lines 0 comments Download
D chrome/common/extensions/file_handler_info.h View 1 chunk +0 lines, -37 lines 0 comments Download
D chrome/common/extensions/file_handler_info.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M extensions/common/common_manifest_handlers.cc View 2 chunks +2 lines, -0 lines 0 comments Download
A + extensions/common/manifest_handlers/file_handler_info.h View 2 chunks +24 lines, -7 lines 0 comments Download
A + extensions/common/manifest_handlers/file_handler_info.cc View 6 chunks +18 lines, -13 lines 0 comments Download
A + extensions/common/manifest_handlers/file_handler_manifest_unittest.cc View 3 chunks +7 lines, -11 lines 0 comments Download
M extensions/extensions.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Devlin
6 years, 7 months ago (2014-05-19 21:36:49 UTC) #1
Yoyo Zhou
LGTM, nice cleanup!
6 years, 7 months ago (2014-05-19 22:38:32 UTC) #2
Devlin
+benwells@ and jackhou@ for c/b/web_applications/. There shouldn't be any functional changes, but it's probably more ...
6 years, 7 months ago (2014-05-19 22:57:32 UTC) #3
benwells
lgtm
6 years, 7 months ago (2014-05-19 23:59:05 UTC) #4
jackhou1
lgtm. Thanks! Removing FileHandlersInfo was on my todo list until now =)
6 years, 7 months ago (2014-05-20 05:02:01 UTC) #5
Devlin
The CQ bit was checked by rdevlin.cronin@chromium.org
6 years, 7 months ago (2014-05-20 16:29:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/280963002/90001
6 years, 7 months ago (2014-05-20 16:30:19 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-05-20 21:14:12 UTC) #8
Message was sent while issue was closed.
Change committed as 271750

Powered by Google App Engine
This is Rietveld 408576698