Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2809603002: Introduce ParameterStructure (Closed)

Created:
3 years, 8 months ago by Johnni Winther
Modified:
3 years, 8 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Introduce ParameterStructure This is a substructure of FunctionType and FunctionSignature which doesn't contain type information. This allows us to let FunctionEntity have a ParameterStructure (which makes sense for both K and J elements) but not require FunctionEntity to have a type (which K elements have but J elements might not). R=efortuna@google.com Committed: https://github.com/dart-lang/sdk/commit/21a3455bd67ddef0970d2da05db94ec85c89459e

Patch Set 1 #

Patch Set 2 : Fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -32 lines) Patch
M pkg/compiler/lib/src/compile_time_constants.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/elements/common.dart View 3 chunks +21 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/elements/elements.dart View 3 chunks +6 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/elements/entities.dart View 2 chunks +26 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 4 chunks +10 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/builder.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/inferrer/closure_tracer.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/kernel/elements.dart View 7 chunks +12 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/kernel/world_builder.dart View 1 3 chunks +15 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/class_hierarchy.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/constructors.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 5 chunks +5 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/resolution/send_structure.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/serialization/modelz.dart View 3 chunks +9 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/universe/call_structure.dart View 3 chunks +6 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/universe/selector.dart View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 8 months ago (2017-04-10 09:44:20 UTC) #2
Emily Fortuna
lgtm
3 years, 8 months ago (2017-04-10 19:54:23 UTC) #3
Johnni Winther
3 years, 8 months ago (2017-04-11 08:19:24 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
21a3455bd67ddef0970d2da05db94ec85c89459e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698