Use off-heap data for type feedback in PolymorphicInstanceCallInstr

runtime/vm/intermediate_language_arm.cc

 
 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_ARM.
 #if defined(TARGET_ARCH_ARM)
 
 #include "vm/intermediate_language.h"
 
@@ skipping 3121 matching lines @@
     Register result = locs->out(0).reg();
     locs->live_registers()->Remove(Location::RegisterLocation(result));
 
     compiler->SaveLiveRegisters(locs);
     if (instruction_->env() != NULL) {
       Environment* env = compiler->SlowPathEnvironmentFor(instruction_);
       compiler->pending_deoptimization_env_ = env;
     }
     __ Push(locs->in(0).reg());
     __ Push(locs->in(1).reg());
+    String& selector =
+        String::Handle(instruction_->call()->ic_data()->target_name());
+    Array& argument_names =
+        Array::Handle(instruction_->call()->ic_data()->arguments_descriptor());
     compiler->EmitMegamorphicInstanceCall(
-        *instruction_->call()->ic_data(), instruction_->call()->ArgumentCount(),
+        selector, argument_names, instruction_->call()->ArgumentCount(),
         instruction_->call()->deopt_id(), instruction_->call()->token_pos(),
         locs, try_index_,
         /* slow_path_argument_count = */ 2);
     __ mov(result, Operand(R0));
     compiler->RestoreLiveRegisters(locs);
     __ b(exit_label());
     compiler->pending_deoptimization_env_ = NULL;
   }
 
  private:
@@ skipping 117 matching lines @@
     Register result = merged_ ? locs->temp(0).reg() : locs->out(0).reg();
     locs->live_registers()->Remove(Location::RegisterLocation(result));
 
     compiler->SaveLiveRegisters(locs);
     if (instruction_->env() != NULL) {
       Environment* env = compiler->SlowPathEnvironmentFor(instruction_);
       compiler->pending_deoptimization_env_ = env;
     }
     __ Push(locs->in(0).reg());
     __ Push(locs->in(1).reg());
+    String& selector =

[Vyacheslav Egorov (Google), 2017/04/10 10:59:28]

const String&

[erikcorry, 2017/04/19 15:06:40]

Done.

+        String::Handle(instruction_->call()->ic_data()->target_name());
+    Array& argument_names =

[Vyacheslav Egorov (Google), 2017/04/10 10:59:28]

const Array&

[erikcorry, 2017/04/19 15:06:40]

Done.

+        Array::Handle(instruction_->call()->ic_data()->arguments_descriptor());
     compiler->EmitMegamorphicInstanceCall(
-        *instruction_->call()->ic_data(), instruction_->call()->ArgumentCount(),
+        selector, argument_names, instruction_->call()->ArgumentCount(),
         instruction_->call()->deopt_id(), instruction_->call()->token_pos(),
         locs, try_index_,
         /* slow_path_argument_count = */ 2);
     __ mov(result, Operand(R0));
     compiler->RestoreLiveRegisters(locs);
     compiler->pending_deoptimization_env_ = NULL;
     if (merged_) {
       __ CompareObject(result, Bool::True());
       __ b(
           instruction_->is_negated() ? labels_.false_label : labels_.true_label,
@@ skipping 3019 matching lines @@
   if (unary_checks().GetReceiverClassIdAt(0) == kSmiCid) {
     __ tst(value, Operand(kSmiTagMask));
     __ b(&is_ok, EQ);
   } else {
     __ tst(value, Operand(kSmiTagMask));
     __ b(deopt, EQ);
   }
   Register biased_cid = temp;
   __ LoadClassId(biased_cid, value);
 
-  GrowableArray<CidRangeTarget> sorted_ic_data;
+  ZoneGrowableArray<CidRangeTarget> sorted_ic_data;
   FlowGraphCompiler::SortICDataByCount(unary_checks(), &sorted_ic_data,
                                        /* drop_smi = */ true);
 
   if (IsDenseSwitch()) {
     ASSERT(cids_[0] < cids_[cids_.length() - 1]);
     __ AddImmediate(biased_cid, -cids_[0]);
     __ CompareImmediate(biased_cid, cids_[cids_.length() - 1] - cids_[0]);
     __ b(deopt, HI);
 
     intptr_t mask = ComputeCidMask();
@@ skipping 929 matching lines @@
   compiler->GenerateRuntimeCall(TokenPosition::kNoSource, deopt_id(),
                                 kGrowRegExpStackRuntimeEntry, 1, locs());
   __ Drop(1);
   __ Pop(result);
 }
 
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_ARM