Fix corner case if another rotation request comes before the copy request finishes.

ash/rotator/screen_rotation_animator.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/rotator/screen_rotation_animator.h"
 
 #include <string>
 #include <utility>
 #include <vector>
 
@@ skipping 403 matching lines @@
   for (auto& observer : screen_rotation_animator_observers_)
     observer.OnScreenRotationAnimationFinished(this);
 }
 
 void ScreenRotationAnimator::set_disable_animation_timers_for_test(
     bool disable_timers) {
   disable_animation_timers_for_test_ = disable_timers;
 }
 
 void ScreenRotationAnimator::StopAnimating() {
+  // |old_layer_tree_owner_| could be nullptr if another rotation request comes
+  // before the copy request finishes. At this time there is no animation.
+  if (!old_layer_tree_owner_)

[oshima, 2017/04/10 18:38:46]

what's the exact call sequence that reaches this condition?

My suggestion is that instead of having simple "bool is_rotating",
define state enum (e.g INIT, COPY_REQUESTED, ROTATING, DONE), and track the
state and do the right thing based
on the state.

[wutao, 2017/04/10 21:19:22]

Add the enum state, please review.

Current sequence is:
1) rotation_request when idle -> rotate -> finish.
2) rotation_request when rotating -> finish current animation to target position
and continue new rotation_request.

When we adding the copy request, the sequence becomes:
1) rotation_request when idle -> send copy request -> wait the copy result ->
rotate -> finish.
2) rotation_request when rotating -> finish current animation to target position
and continue new rotation_request.
3) rotation_request when wait the copy result -> I think we should ignore the
rotation request during this time. Otherwise, we need cancel the copy request
and abort current rotation. This complicates the situation and gain little from
it.

+    return;
+
   aura::Window* root_window = GetRootWindow(display_id_);
   for (ui::Layer* child_layer : root_window->layer()->children()) {
     if (child_layer == old_layer_tree_owner_->root())
       continue;
 
     child_layer->GetAnimator()->StopAnimating();
   }
 
   old_layer_tree_owner_->root()->GetAnimator()->StopAnimating();
 }
 
 }  // namespace ash