Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Unified Diff: ios/chrome/browser/web_state_list/web_state_list_observer_bridge.h

Issue 2809543003: [ios] Change WebStateListObserverBridge to use weak reference. (Closed)
Patch Set: Fix DCHECK in WebStateList's ObserverList destructor. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/web_state_list/web_state_list_fast_enumeration_helper.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/web_state_list/web_state_list_observer_bridge.h
diff --git a/ios/chrome/browser/web_state_list/web_state_list_observer_bridge.h b/ios/chrome/browser/web_state_list/web_state_list_observer_bridge.h
index ccdcbbb4e66b5e8fc7e1c9f84012a98697f0a997..541c2e4aad5b199e73f6ad647b0202782b651aac 100644
--- a/ios/chrome/browser/web_state_list/web_state_list_observer_bridge.h
+++ b/ios/chrome/browser/web_state_list/web_state_list_observer_bridge.h
@@ -7,6 +7,7 @@
#import <Foundation/Foundation.h>
+#import "base/ios/weak_nsobject.h"
#include "base/macros.h"
#import "ios/chrome/browser/web_state_list/web_state_list_observer.h"
@@ -66,7 +67,7 @@
@end
// Observer that bridges WebStateList events to an Objective-C observer that
-// implements the WebStateListObserver protocol (the observer is owned).
+// implements the WebStateListObserver protocol (the observer is *not* owned).
class WebStateListObserverBridge : public WebStateListObserver {
public:
explicit WebStateListObserverBridge(id<WebStateListObserving> observer);
@@ -100,7 +101,7 @@ class WebStateListObserverBridge : public WebStateListObserver {
int active_index,
bool user_action) override;
- id<WebStateListObserving> observer_;
+ base::WeakNSProtocol<id<WebStateListObserving>> observer_;
DISALLOW_COPY_AND_ASSIGN(WebStateListObserverBridge);
};
« no previous file with comments | « ios/chrome/browser/web_state_list/web_state_list_fast_enumeration_helper.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698