Content side of languagechange event fired on accept languages changes.

Content side of languagechange event fired on accept languages changes.

This call the WebView API to notify the pages that the accept languages
has changed and setup the test runner to allow Blink to change the
accept languages for test purposes.

Depends on https://codereview.chromium.org/284793003/

BUG=365123
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273076

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273230

[jochen (gone - plz use gerrit), 2014-05-14 08:11:07]

I think it's better to just override WebTestProxy::acceptLanguages - it should
forward to WebTestProxyBase, and the TestRunner can just modify the state of the
WebTestProxyBase

[mlamouri (slow - plz ping), 2014-05-15 07:31:47]

On 2014/05/14 08:11:07, jochen wrote:
> I think it's better to just override WebTestProxy::acceptLanguages - it should
> forward to WebTestProxyBase, and the TestRunner can just modify the state of
the
> WebTestProxyBase

Could you elaborate more? I'm not sure I follow what you mean. Why do you want
me to call WebTestProxy::acceptLanguages()? You don't want me to change the
state of the render_view? It's not clear to me what WebTestProxy is for TBH and
I feel that I'm missing something here :)

[jochen (gone - plz use gerrit), 2014-05-15 10:03:25]

On 2014/05/15 07:31:47, Mounir Lamouri wrote:
> On 2014/05/14 08:11:07, jochen wrote:
> > I think it's better to just override WebTestProxy::acceptLanguages - it
should
> > forward to WebTestProxyBase, and the TestRunner can just modify the state of
> the
> > WebTestProxyBase
> 
> Could you elaborate more? I'm not sure I follow what you mean. Why do you want
> me to call WebTestProxy::acceptLanguages()? You don't want me to change the
> state of the render_view? It's not clear to me what WebTestProxy is for TBH
and
> I feel that I'm missing something here :)

during layout tests, we don't use content::RenderViewImpl objects, but
WebTestProxy<RenderViewImpl> objects, so you override all virtual methods.

WebTestProxy derives from RenderViewImpl and WebTestProxyBase, so you can either
handle a method in WebTestProxyBase, or forward it to RenderViewImpl (or both)

that way, you don't need to add so much test only code to renderviewimpl

[mlamouri (slow - plz ping), 2014-05-23 12:49:36]

I am now using WebTestProxy, PTAL. I'm a bit concerned by the hard coded "en-US"
during tests but I guess anyway, we want a known value for tests. Do you have a
better idea?

[jochen (gone - plz use gerrit), 2014-05-23 12:54:17]

how will you reset the languages between tests?

https://codereview.chromium.org/280953002/diff/20001/content/shell/renderer/t...
File content/shell/renderer/test_runner/web_test_proxy.h (right):

https://codereview.chromium.org/280953002/diff/20001/content/shell/renderer/t...
content/shell/renderer/test_runner/web_test_proxy.h:348: return
WebTestProxy::acceptLanguages();
should be WebTestProxyBase

[mlamouri (slow - plz ping), 2014-05-23 13:00:34]

On 2014/05/23 12:54:17, jochen wrote:
> how will you reset the languages between tests?

We keep the same instance between different LayoutTests?

[jochen (gone - plz use gerrit), 2014-05-23 13:03:53]

On 2014/05/23 13:00:34, Mounir Lamouri wrote:
> On 2014/05/23 12:54:17, jochen wrote:
> > how will you reset the languages between tests?
> 
> We keep the same instance between different LayoutTests?

yes, we just navigate the webview around. There's a TestRunner::reset method or
something that runs between tests.

[mlamouri (slow - plz ping), 2014-05-23 13:09:35]

On 2014/05/23 13:03:53, jochen wrote:
> On 2014/05/23 13:00:34, Mounir Lamouri wrote:
> > On 2014/05/23 12:54:17, jochen wrote:
> > > how will you reset the languages between tests?
> > 
> > We keep the same instance between different LayoutTests?
> 
> yes, we just navigate the webview around. There's a TestRunner::reset method
or
> something that runs between tests.

I've updated the patch: WebTestRunner::Reset() calls WebTestProxy::Reset() so
I've move accept_languages_ = "en-US"; there.

PTAL :)

[jochen (gone - plz use gerrit), 2014-05-23 13:12:08]

lgtm

maybe you want to send a CL that adds the public API as dummy so you can land
this?

https://codereview.chromium.org/280953002/diff/40001/content/renderer/render_...
File content/renderer/render_view_impl.cc (right):

https://codereview.chromium.org/280953002/diff/40001/content/renderer/render_...
content/renderer/render_view_impl.cc:2957: webview()->acceptLanguagesChanged();
this API doesn't exist yet, no?

[mlamouri (slow - plz ping), 2014-05-23 13:15:17]

https://codereview.chromium.org/280953002/diff/40001/content/renderer/render_...
File content/renderer/render_view_impl.cc (right):

https://codereview.chromium.org/280953002/diff/40001/content/renderer/render_...
content/renderer/render_view_impl.cc:2957: webview()->acceptLanguagesChanged();
On 2014/05/23 13:12:09, jochen wrote:
> this API doesn't exist yet, no?

It is being added in https://codereview.chromium.org/284793003/
You did a review pass, I addressed your comments. Hopefully, it's close enough
to land ;)

[mlamouri (slow - plz ping), 2014-05-25 13:06:19]

The CQ bit was checked by mlamouri@chromium.org

[commit-bot: I haz the power, 2014-05-25 13:06:29]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mlamouri@chromium.org/280953002/40001

[commit-bot: I haz the power, 2014-05-25 14:58:41]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/18...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/8958)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/12040)

[commit-bot: I haz the power, 2014-05-25 15:03:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-25 15:03:45]

Try jobs failed on following builders:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)

[mlamouri (slow - plz ping), 2014-05-26 19:36:29]

The CQ bit was checked by mlamouri@chromium.org

[commit-bot: I haz the power, 2014-05-26 19:37:15]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mlamouri@chromium.org/280953002/40001

[commit-bot: I haz the power, 2014-05-26 23:12:49]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/12274)

[commit-bot: I haz the power, 2014-05-26 23:48:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-26 23:48:20]

Try jobs failed on following builders:
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)

[mlamouri (slow - plz ping), 2014-05-27 08:28:58]

The CQ bit was checked by mlamouri@chromium.org

[commit-bot: I haz the power, 2014-05-27 08:29:27]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mlamouri@chromium.org/280953002/40001

[commit-bot: I haz the power, 2014-05-27 10:11:22]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/12384)

[mlamouri (slow - plz ping), 2014-05-27 10:35:29]

The CQ bit was unchecked by mlamouri@chromium.org

[mlamouri (slow - plz ping), 2014-05-27 20:12:25]

The CQ bit was checked by mlamouri@chromium.org

[commit-bot: I haz the power, 2014-05-27 20:12:44]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mlamouri@chromium.org/280953002/60001

[commit-bot: I haz the power, 2014-05-27 23:59:20]

Change committed as 273076

[tkent, 2014-05-28 01:45:19]

On 2014/05/27 23:59:20, I haz the power (commit-bot) wrote:
> Change committed as 273076

It broke two layout tests which are related to accept languages.
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40...

[tkent, 2014-05-28 03:08:51]

A revert of this CL has been created in
https://codereview.chromium.org/305633005/ by tkent@chromium.org.

The reason for reverting is: Broke two layout tests:
fast/forms/validationMessage.html and fast/forms/email-idn-conversion.html

BUG=378129
.

[mlamouri (slow - plz ping), 2014-05-28 11:33:41]

The CQ bit was checked by mlamouri@chromium.org

[commit-bot: I haz the power, 2014-05-28 11:34:16]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mlamouri@chromium.org/280953002/80001

[commit-bot: I haz the power, 2014-05-28 13:28:41]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)

[commit-bot: I haz the power, 2014-05-28 13:40:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-28 13:40:25]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)

[mlamouri (slow - plz ping), 2014-05-28 13:46:01]

The CQ bit was checked by mlamouri@chromium.org

[commit-bot: I haz the power, 2014-05-28 13:46:56]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mlamouri@chromium.org/280953002/80001

[commit-bot: I haz the power, 2014-05-28 13:54:29]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)

[commit-bot: I haz the power, 2014-05-28 14:04:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-28 14:04:01]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)

[mlamouri (slow - plz ping), 2014-05-28 14:06:09]

The CQ bit was checked by mlamouri@chromium.org

[commit-bot: I haz the power, 2014-05-28 14:06:28]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mlamouri@chromium.org/280953002/80001

[commit-bot: I haz the power, 2014-05-28 14:11:38]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)

[commit-bot: I haz the power, 2014-05-28 14:16:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-28 14:16:27]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)

[mlamouri (slow - plz ping), 2014-05-28 14:44:00]

The CQ bit was checked by mlamouri@chromium.org

[commit-bot: I haz the power, 2014-05-28 14:44:35]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mlamouri@chromium.org/280953002/80001

[commit-bot: I haz the power, 2014-05-28 14:51:22]

Change committed as 273230