Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2809523002: Issue 29288. Resynthesize Import/Export/PartElement for every directive. (Closed)

Created:
3 years, 8 months ago by scheglov
Modified:
3 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Issue 29288. Resynthesize Import/Export/PartElement for every directive. We need all of them because there might be associated annotations, which should be applied to corresponding AST nodes. https://github.com/dart-lang/sdk/issues/29288 https://github.com/dart-lang/sdk/issues/29188 R=brianwilkerson@google.com BUG= https://github.com/dart-lang/sdk/issues/29288 Committed: https://github.com/dart-lang/sdk/commit/021d99e05deae069352f5b8d2c00f1ef0b1f00f3

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+298 lines, -129 lines) Patch
M pkg/analyzer/lib/src/dart/analysis/file_state.dart View 7 chunks +42 lines, -24 lines 0 comments Download
M pkg/analyzer/lib/src/dart/analysis/index.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/dart/analysis/library_analyzer.dart View 8 chunks +69 lines, -52 lines 1 comment Download
M pkg/analyzer/lib/src/dart/element/element.dart View 2 chunks +8 lines, -18 lines 0 comments Download
M pkg/analyzer/lib/src/generated/declaration_resolver.dart View 3 chunks +6 lines, -0 lines 1 comment Download
M pkg/analyzer/lib/src/summary/resynthesize.dart View 4 chunks +13 lines, -13 lines 0 comments Download
M pkg/analyzer/test/src/dart/analysis/driver_test.dart View 2 chunks +6 lines, -7 lines 0 comments Download
M pkg/analyzer/test/src/dart/analysis/file_state_test.dart View 6 chunks +31 lines, -6 lines 0 comments Download
M pkg/analyzer/test/src/dart/analysis/index_test.dart View 1 chunk +14 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/summary/element_text.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_ast_test.dart View 2 chunks +5 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_common.dart View 8 chunks +92 lines, -0 lines 0 comments Download
M pkg/analyzer_cli/lib/src/analyzer_impl.dart View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 8 months ago (2017-04-08 17:03:33 UTC) #1
Brian Wilkerson
lgtm https://codereview.chromium.org/2809523002/diff/1/pkg/analyzer/lib/src/dart/analysis/library_analyzer.dart File pkg/analyzer/lib/src/dart/analysis/library_analyzer.dart (right): https://codereview.chromium.org/2809523002/diff/1/pkg/analyzer/lib/src/dart/analysis/library_analyzer.dart#newcode457 pkg/analyzer/lib/src/dart/analysis/library_analyzer.dart:457: // name as the library. "name" --> "name ...
3 years, 8 months ago (2017-04-09 16:01:24 UTC) #2
scheglov
3 years, 8 months ago (2017-04-09 17:12:48 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
021d99e05deae069352f5b8d2c00f1ef0b1f00f3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698