Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Side by Side Diff: net/http/http_stream_factory_impl.h

Issue 2809453002: Add JobController/Job count to UMA histograms when the count hits limit (Closed)
Patch Set: change the boundary to a multiple of 100 Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_HTTP_HTTP_STREAM_FACTORY_IMPL_H_ 5 #ifndef NET_HTTP_HTTP_STREAM_FACTORY_IMPL_H_
6 #define NET_HTTP_HTTP_STREAM_FACTORY_IMPL_H_ 6 #define NET_HTTP_HTTP_STREAM_FACTORY_IMPL_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 #include <map> 10 #include <map>
(...skipping 153 matching lines...) Expand 10 before | Expand all | Expand 10 after
164 PrivacyMode privacy_mode); 164 PrivacyMode privacy_mode);
165 165
166 // Notifies |this| that a stream to the proxy server contained in |proxy_info| 166 // Notifies |this| that a stream to the proxy server contained in |proxy_info|
167 // with privacy mode |privacy_mode| is ready. 167 // with privacy mode |privacy_mode| is ready.
168 void OnStreamReady(const ProxyInfo& proxy_info, PrivacyMode privacy_mode); 168 void OnStreamReady(const ProxyInfo& proxy_info, PrivacyMode privacy_mode);
169 169
170 // Returns true if |proxy_info| contains a proxy server that supports request 170 // Returns true if |proxy_info| contains a proxy server that supports request
171 // priorities. 171 // priorities.
172 bool ProxyServerSupportsPriorities(const ProxyInfo& proxy_info) const; 172 bool ProxyServerSupportsPriorities(const ProxyInfo& proxy_info) const;
173 173
174 // Add the count of JobControllers that are not completed to UMA histogram if
175 // the count hits the limit: 100, 200, 400, etc. Break down JobControllers
xunjieli 2017/04/10 23:49:14 nit: if the count are multiples of 100.
xunjieli 2017/04/11 00:14:22 hmm.. I don't see this one in the new patch. Cou
Zhongyi Shi 2017/04/11 00:21:22 Done. Whoops, I updated in histograms.xml and forg
176 // count based on the type of JobController.
177 void AddJobControllerCountToHistograms() const;
178
174 HttpNetworkSession* const session_; 179 HttpNetworkSession* const session_;
175 180
176 // All Requests/Preconnects are assigned with a JobController to manage 181 // All Requests/Preconnects are assigned with a JobController to manage
177 // serving Job(s). JobController might outlive Request when Request 182 // serving Job(s). JobController might outlive Request when Request
178 // is served while there's some working Job left. JobController will be 183 // is served while there's some working Job left. JobController will be
179 // deleted from |job_controller_set_| when it determines the completion of 184 // deleted from |job_controller_set_| when it determines the completion of
180 // its work. 185 // its work.
181 JobControllerSet job_controller_set_; 186 JobControllerSet job_controller_set_;
182 187
183 // Factory used by job controllers for creating jobs. 188 // Factory used by job controllers for creating jobs.
184 std::unique_ptr<JobFactory> job_factory_; 189 std::unique_ptr<JobFactory> job_factory_;
185 190
186 // Set of proxy servers that support request priorities to which subsequent 191 // Set of proxy servers that support request priorities to which subsequent
187 // preconnects should be skipped. 192 // preconnects should be skipped.
188 std::set<PreconnectingProxyServer> preconnecting_proxy_servers_; 193 std::set<PreconnectingProxyServer> preconnecting_proxy_servers_;
189 194
190 SpdySessionRequestMap spdy_session_request_map_; 195 SpdySessionRequestMap spdy_session_request_map_;
191 196
192 const bool for_websockets_; 197 const bool for_websockets_;
193 198
194 DISALLOW_COPY_AND_ASSIGN(HttpStreamFactoryImpl); 199 DISALLOW_COPY_AND_ASSIGN(HttpStreamFactoryImpl);
195 }; 200 };
196 201
197 } // namespace net 202 } // namespace net
198 203
199 #endif // NET_HTTP_HTTP_STREAM_FACTORY_IMPL_H_ 204 #endif // NET_HTTP_HTTP_STREAM_FACTORY_IMPL_H_
OLDNEW
« no previous file with comments | « no previous file | net/http/http_stream_factory_impl.cc » ('j') | tools/metrics/histograms/histograms.xml » ('J')

Powered by Google App Engine
This is Rietveld 408576698