Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(750)

Unified Diff: pkg/analyzer/lib/src/dart/element/builder.dart

Issue 2809423003: Build GenericFunctionTypeElementImpl in both ApiElementBuilder and LocalElementBuilder. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analyzer/test/dart/element/builder_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/dart/element/builder.dart
diff --git a/pkg/analyzer/lib/src/dart/element/builder.dart b/pkg/analyzer/lib/src/dart/element/builder.dart
index bd5767ab9d65224c82cb787e34f1571f3892e62c..a396d4d65df61aa313db7433095cf30a6fbaacc7 100644
--- a/pkg/analyzer/lib/src/dart/element/builder.dart
+++ b/pkg/analyzer/lib/src/dart/element/builder.dart
@@ -398,22 +398,6 @@ class ApiElementBuilder extends _BaseElementBuilder {
}
@override
- Object visitGenericFunctionType(GenericFunctionType node) {
- ElementHolder holder = new ElementHolder();
- _visitChildren(holder, node);
- GenericFunctionTypeElementImpl element =
- new GenericFunctionTypeElementImpl.forOffset(node.beginToken.offset);
- _setCodeRange(element, node);
- element.parameters = holder.parameters;
- element.typeParameters = holder.typeParameters;
- FunctionType type = new FunctionTypeImpl(element);
- element.type = type;
- (node as GenericFunctionTypeImpl).type = type;
- holder.validate();
- return null;
- }
-
- @override
Object visitGenericTypeAlias(GenericTypeAlias node) {
ElementHolder holder = new ElementHolder();
_visitChildren(holder, node);
@@ -1481,6 +1465,22 @@ abstract class _BaseElementBuilder extends RecursiveAstVisitor<Object> {
}
@override
+ Object visitGenericFunctionType(GenericFunctionType node) {
+ ElementHolder holder = new ElementHolder();
+ _visitChildren(holder, node);
+ GenericFunctionTypeElementImpl element =
+ new GenericFunctionTypeElementImpl.forOffset(node.beginToken.offset);
+ _setCodeRange(element, node);
+ element.parameters = holder.parameters;
+ element.typeParameters = holder.typeParameters;
+ FunctionType type = new FunctionTypeImpl(element);
+ element.type = type;
+ (node as GenericFunctionTypeImpl).type = type;
+ holder.validate();
+ return null;
+ }
+
+ @override
Object visitSimpleFormalParameter(SimpleFormalParameter node) {
ParameterElementImpl parameter;
if (node.parent is! DefaultFormalParameter) {
« no previous file with comments | « no previous file | pkg/analyzer/test/dart/element/builder_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698