Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2809423003: Build GenericFunctionTypeElementImpl in both ApiElementBuilder and LocalElementBuilder. (Closed)

Created:
3 years, 8 months ago by scheglov
Modified:
3 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Build GenericFunctionTypeElementImpl in both ApiElementBuilder and LocalElementBuilder. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/214308773419d67e9380dca38c7332dbd8496988

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -16 lines) Patch
M pkg/analyzer/lib/src/dart/element/builder.dart View 2 chunks +16 lines, -16 lines 0 comments Download
M pkg/analyzer/test/dart/element/builder_test.dart View 2 chunks +23 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 8 months ago (2017-04-12 16:30:49 UTC) #1
Brian Wilkerson
lgtm
3 years, 8 months ago (2017-04-12 16:33:57 UTC) #2
scheglov
3 years, 8 months ago (2017-04-12 16:39:39 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
214308773419d67e9380dca38c7332dbd8496988 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698