Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Unified Diff: third_party/WebKit/Source/web/tests/WebViewTest.cpp

Issue 2809333002: WIP Logging for Contextual Search: Node->Element. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/WebViewTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/WebViewTest.cpp b/third_party/WebKit/Source/web/tests/WebViewTest.cpp
index c9ad3a734fead5b4278e893275c31a8ecceb0186..db0c8533b45700632a1167c6a4ed55194ea6f044 100644
--- a/third_party/WebKit/Source/web/tests/WebViewTest.cpp
+++ b/third_party/WebKit/Source/web/tests/WebViewTest.cpp
@@ -3691,7 +3691,7 @@ TEST_P(WebViewTest, ShowUnhandledTapUIIfNeeded) {
EXPECT_EQ(64, client.GetTappedXPos());
EXPECT_EQ(278, client.GetTappedYPos());
EXPECT_FALSE(client.IsTappedNodeNull());
- EXPECT_TRUE(client.GetWebNode().IsTextNode());
+ EXPECT_FALSE(client.GetWebNode().IsTextNode());
// Test basic tap handling and notification.
client.Reset();
@@ -3701,11 +3701,10 @@ TEST_P(WebViewTest, ShowUnhandledTapUIIfNeeded) {
EXPECT_EQ(144, client.GetTappedXPos());
EXPECT_EQ(82, client.GetTappedYPos());
EXPECT_FALSE(client.IsTappedNodeNull());
- EXPECT_TRUE(client.GetWebNode().IsTextNode());
- // Make sure the returned text node has the parent element that was our
- // target.
+ EXPECT_FALSE(client.GetWebNode().IsTextNode());
+ // Make sure the returned element was our target.
EXPECT_EQ(web_view->MainFrame()->GetDocument().GetElementById("target"),
- client.GetWebNode().ParentNode());
+ client.GetWebNode());
// Test correct conversion of coordinates to viewport space under pinch-zoom.
web_view->SetPageScaleFactor(2);

Powered by Google App Engine
This is Rietveld 408576698