chrome/browser/extensions/external_loader.h - Issue 2809293004: Fix windows registry loader to carry over prefs from file thread correctly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/external_loader.h

Issue 2809293004: Fix windows registry loader to carry over prefs from file thread correctly (Closed)

Patch Set: add TODO Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/external_loader.h

diff --git a/chrome/browser/extensions/external_loader.h b/chrome/browser/extensions/external_loader.h

index ecc11d68439e641636a20656c97ccd919458faf8..83948dbc22087db8c5f40d0efbc0bcfd9ee80b0e 100644

--- a/chrome/browser/extensions/external_loader.h

+++ b/chrome/browser/extensions/external_loader.h

@@ -69,6 +69,8 @@ class ExternalLoader : public base::RefCountedThreadSafe<ExternalLoader> {

// this task should invoke |LoadFinished| with a PostTask. This scheme of

// posting tasks will avoid concurrent access and imply the necessary memory

// barriers.

+ // TODO(lazyboy): To avoid |prefs_| getting unexpectedly overwritten before it

+ // is consumed, consider passing the prefs directly in LoadFinished().

std::unique_ptr<base::DictionaryValue> prefs_;

private:

« no previous file with comments | « no previous file | chrome/browser/extensions/external_registry_loader_win.h » ('j') | no next file with comments »