Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: pkg/compiler/lib/src/js_emitter/code_emitter_task.dart

Issue 2809203003: Remove Compiler/JavaScriptBackend from metadata_collector (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_emitter/code_emitter_task.dart
diff --git a/pkg/compiler/lib/src/js_emitter/code_emitter_task.dart b/pkg/compiler/lib/src/js_emitter/code_emitter_task.dart
index cb69608cf8ba3ccc35204bc3479f9573b996ebbe..d6af687b7c46b5e3bfe0ab0b01c1a9ccf9a87a9e 100644
--- a/pkg/compiler/lib/src/js_emitter/code_emitter_task.dart
+++ b/pkg/compiler/lib/src/js_emitter/code_emitter_task.dart
@@ -14,6 +14,7 @@ import '../deferred_load.dart' show OutputUnit;
import '../elements/entities.dart';
import '../js/js.dart' as jsAst;
import '../js_backend/js_backend.dart' show JavaScriptBackend, Namer;
+import '../universe/world_builder.dart' show CodegenWorldBuilder;
import '../world.dart' show ClosedWorld;
import 'full_emitter/emitter.dart' as full_js_emitter;
import 'lazy_emitter/emitter.dart' as lazy_js_emitter;
@@ -156,11 +157,21 @@ class CodeEmitterTask extends CompilerTask {
}
/// Creates the [Emitter] for this task.
- void createEmitter(Namer namer, ClosedWorld closedWorld) {
+ void createEmitter(Namer namer, ClosedWorld closedWorld,
+ CodegenWorldBuilder codegenWorldBuilder) {
measure(() {
_emitter = _emitterFactory.createEmitter(this, namer, closedWorld);
- metadataCollector = new MetadataCollector(compiler, _emitter);
- typeTestRegistry = new TypeTestRegistry(compiler, closedWorld);
+ metadataCollector = new MetadataCollector(
+ compiler.options,
+ compiler.reporter,
+ compiler.deferredLoadTask,
+ _emitter,
+ backend.constants,
+ backend.typeVariableCodegenAnalysis,
+ backend.mirrorsData,
+ backend.rtiEncoder);
+ typeTestRegistry = new TypeTestRegistry(
+ codegenWorldBuilder, compiler.backend, closedWorld);
});
}

Powered by Google App Engine
This is Rietveld 408576698