Remove Compiler/JavaScriptBackend from metadata_collector

Remove Compiler/JavaScriptBackend from metadata_collector

- and Compiler from type_test_registry.

The CodeEmitterTask was removed from the TypeRepresentationGenerator to
break a dependency cycle between the two. An Emitter is now provided as
an argument to TypeRepresentationGenerator methods instead.

This is a step towards passing data object to the codegen/emitter
instead of pulling data directly from Compiler/JavaScriptBackend. This
is needed to support an element model switch between codegen and
resolution.

R=efortuna@google.com

Committed: https://github.com/dart-lang/sdk/commit/e484e652e2e71d900a5c5b78b779ff11597cd630

[Johnni Winther, 2017-04-12 09:22:32]

johnniwinther@google.com changed reviewers:
+ efortuna@google.com

[Emily Fortuna, 2017-04-12 17:57:35]

lgtm

https://codereview.chromium.org/2809203003/diff/1/pkg/compiler/lib/src/js_bac...
File pkg/compiler/lib/src/js_backend/runtime_types.dart (right):

https://codereview.chromium.org/2809203003/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/runtime_types.dart:974:
visitMalformedType(MalformedType type, Emitter emitter) {
just curious why we added this if we're not using emitter in this instance

[Johnni Winther, 2017-04-18 07:47:01]

https://codereview.chromium.org/2809203003/diff/1/pkg/compiler/lib/src/js_bac...
File pkg/compiler/lib/src/js_backend/runtime_types.dart (right):

https://codereview.chromium.org/2809203003/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/runtime_types.dart:974:
visitMalformedType(MalformedType type, Emitter emitter) {
On 2017/04/12 17:57:35, Emily Fortuna wrote:
> just curious why we added this if we're not using emitter in this instance

We're using it in getJavaScriptClassName.

[Johnni Winther, 2017-04-18 07:58:34]

Description was changed from

==========
Remove Compiler/JavaScriptBackend from metadata_collector

- and Compiler from type_test_registry.

The CodeEmitterTask was removed from the TypeRepresentationGenerator to
break a dependency cycle between the two. An Emitter is now provided as
an argument to TypeRepresentationGenerator methods instead.

This is a step towards passing data object to the codegen/emitter
instead of pulling data directly from Compiler/JavaScriptBackend. This
is needed to support an element model switch between codegen and
resolution.
==========

to

==========
Remove Compiler/JavaScriptBackend from metadata_collector

- and Compiler from type_test_registry.

The CodeEmitterTask was removed from the TypeRepresentationGenerator to
break a dependency cycle between the two. An Emitter is now provided as
an argument to TypeRepresentationGenerator methods instead.

This is a step towards passing data object to the codegen/emitter
instead of pulling data directly from Compiler/JavaScriptBackend. This
is needed to support an element model switch between codegen and
resolution.

R=efortuna@google.com

Committed:
https://github.com/dart-lang/sdk/commit/e484e652e2e71d900a5c5b78b779ff11597cd630
==========

[Johnni Winther, 2017-04-18 07:58:36]

Committed patchset #1 (id:1) manually as
e484e652e2e71d900a5c5b78b779ff11597cd630 (presubmit successful).