components/payments/content/android/payment_manifest_parser_android.cc - Issue 2809193002: Fix crash in release mode of payment manifest parser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/payments/content/android/payment_manifest_parser_android.cc

Issue 2809193002: Fix crash in release mode of payment manifest parser. (Closed)

Patch Set: Fix crash. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/payments/content/android/java/src/org/chromium/components/payments/PaymentManifestDownloader.java ('k') | components/payments/content/payment_manifest_parser_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/payments/content/android/payment_manifest_parser_android.cc

diff --git a/components/payments/content/android/payment_manifest_parser_android.cc b/components/payments/content/android/payment_manifest_parser_android.cc

index f32abb67cf5a5fbb60783bf10140a6fdaf62d4d5..65a3e26e4496a2c186467878ae5fd93662aaef06 100644

--- a/components/payments/content/android/payment_manifest_parser_android.cc

+++ b/components/payments/content/android/payment_manifest_parser_android.cc

@@ -41,10 +41,11 @@ class ParseCallback {

env, web_app_manifest_urls.size());

for (size_t i = 0; i < web_app_manifest_urls.size(); ++i) {

- DCHECK(Java_PaymentManifestParser_addUri(

+ bool is_valid_uri = Java_PaymentManifestParser_addUri(

env, juris.obj(), base::checked_cast<int>(i),

base::android::ConvertUTF8ToJavaString(

- env, web_app_manifest_urls[i].spec())));

+ env, web_app_manifest_urls[i].spec()));

+ DCHECK(is_valid_uri);

}

// Can trigger synchronous deletion of PaymentManifestParserAndroid.