Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2782)

Unified Diff: base/task_scheduler/task_scheduler_impl_unittest.cc

Issue 2809163003: Always use TaskScheduler::InitParams to initialize a TaskScheduler. (Closed)
Patch Set: fix-build-error Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/task_scheduler/task_scheduler_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/task_scheduler/task_scheduler_impl_unittest.cc
diff --git a/base/task_scheduler/task_scheduler_impl_unittest.cc b/base/task_scheduler/task_scheduler_impl_unittest.cc
index e0f88691bba14bb1abe5b64c767a5b5de844678c..04ddc6fdfd4da5b75d7fb8f72744d339872728af 100644
--- a/base/task_scheduler/task_scheduler_impl_unittest.cc
+++ b/base/task_scheduler/task_scheduler_impl_unittest.cc
@@ -175,23 +175,6 @@ std::vector<TraitsExecutionModePair> GetTraitsExecutionModePairs() {
return params;
}
-enum WorkerPoolType {
- BACKGROUND_WORKER_POOL = 0,
- BACKGROUND_BLOCKING_WORKER_POOL,
- FOREGROUND_WORKER_POOL,
- FOREGROUND_BLOCKING_WORKER_POOL,
-};
-
-size_t GetThreadPoolIndexForTraits(const TaskTraits& traits) {
- if (traits.may_block()) {
- return traits.priority() == TaskPriority::BACKGROUND
- ? BACKGROUND_BLOCKING_WORKER_POOL
- : FOREGROUND_BLOCKING_WORKER_POOL;
- }
- return traits.priority() == TaskPriority::BACKGROUND ? BACKGROUND_WORKER_POOL
- : FOREGROUND_WORKER_POOL;
-}
-
class TaskSchedulerImplTest
: public testing::TestWithParam<TraitsExecutionModePair> {
protected:
@@ -200,27 +183,22 @@ class TaskSchedulerImplTest
void SetUp() override {
using StandbyThreadPolicy = SchedulerWorkerPoolParams::StandbyThreadPolicy;
- std::vector<SchedulerWorkerPoolParams> params_vector;
-
- ASSERT_EQ(BACKGROUND_WORKER_POOL, params_vector.size());
- params_vector.emplace_back("Background", ThreadPriority::BACKGROUND,
- StandbyThreadPolicy::LAZY, 1U, TimeDelta::Max());
-
- ASSERT_EQ(BACKGROUND_BLOCKING_WORKER_POOL, params_vector.size());
- params_vector.emplace_back("BackgroundBlocking", ThreadPriority::BACKGROUND,
- StandbyThreadPolicy::LAZY, 3U, TimeDelta::Max());
-
- ASSERT_EQ(FOREGROUND_WORKER_POOL, params_vector.size());
- params_vector.emplace_back("Foreground", ThreadPriority::NORMAL,
- StandbyThreadPolicy::LAZY, 4U, TimeDelta::Max());
-
- ASSERT_EQ(FOREGROUND_BLOCKING_WORKER_POOL, params_vector.size());
- params_vector.emplace_back("ForegroundBlocking", ThreadPriority::NORMAL,
- StandbyThreadPolicy::LAZY, 12U,
- TimeDelta::Max());
+ constexpr TimeDelta kSuggestedReclaimTime = TimeDelta::FromSeconds(30);
+ constexpr int kMaxNumBackgroundThreads = 1;
+ constexpr int kMaxNumBackgroundBlockingThreads = 3;
+ constexpr int kMaxNumForegroundThreads = 4;
+ constexpr int kMaxNumForegroundBlockingThreads = 12;
+
+ scheduler_ = TaskSchedulerImpl::Create(
+ "Test", {{StandbyThreadPolicy::LAZY, kMaxNumBackgroundThreads,
+ kSuggestedReclaimTime},
+ {StandbyThreadPolicy::LAZY, kMaxNumBackgroundBlockingThreads,
+ kSuggestedReclaimTime},
+ {StandbyThreadPolicy::LAZY, kMaxNumForegroundThreads,
+ kSuggestedReclaimTime},
+ {StandbyThreadPolicy::LAZY, kMaxNumForegroundBlockingThreads,
+ kSuggestedReclaimTime}});
- scheduler_ = TaskSchedulerImpl::Create(params_vector,
- Bind(&GetThreadPoolIndexForTraits));
ASSERT_TRUE(scheduler_);
}
« no previous file with comments | « base/task_scheduler/task_scheduler_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698