Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3333)

Unified Diff: base/task_scheduler/task_scheduler.h

Issue 2809163003: Always use TaskScheduler::InitParams to initialize a TaskScheduler. (Closed)
Patch Set: fix-build-error Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/task_scheduler/scheduler_worker_pool_impl.cc ('k') | base/task_scheduler/task_scheduler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/task_scheduler/task_scheduler.h
diff --git a/base/task_scheduler/task_scheduler.h b/base/task_scheduler/task_scheduler.h
index d19841f3ba8f1266b7c169c098ab6dfb8cda1f1a..26f33adfefa1d207c8573da4b4d132b6f09cf396 100644
--- a/base/task_scheduler/task_scheduler.h
+++ b/base/task_scheduler/task_scheduler.h
@@ -54,12 +54,6 @@ class BASE_EXPORT TaskScheduler {
const SchedulerWorkerPoolParams foreground_blocking_worker_pool_params;
};
- // Returns the index of the worker pool in which a task with |traits| should
- // run. This should be coded in a future-proof way: new traits should
- // gracefully map to a default pool.
- using WorkerPoolIndexForTraitsCallback =
- Callback<size_t(const TaskTraits& traits)>;
-
// Destroying a TaskScheduler is not allowed in production; it is always
// leaked. In tests, it should only be destroyed after JoinForTesting() has
// returned.
@@ -146,18 +140,6 @@ class BASE_EXPORT TaskScheduler {
static void CreateAndSetSimpleTaskScheduler(const std::string& name);
#endif // !defined(OS_NACL)
- // Creates and sets a task scheduler with custom worker pools. CHECKs on
- // failure. |worker_pool_params_vector| describes the worker pools to create.
- // |worker_pool_index_for_traits_callback| returns the index in |worker_pools|
- // of the worker pool in which a task with given traits should run. For tests,
- // prefer base::test::ScopedTaskScheduler (ensures isolation).
- //
- // Deprecated. Use the overload below instead. https://crbug.com/690706
- static void CreateAndSetDefaultTaskScheduler(
- const std::vector<SchedulerWorkerPoolParams>& worker_pool_params_vector,
- const WorkerPoolIndexForTraitsCallback&
- worker_pool_index_for_traits_callback);
-
// Creates and sets a task scheduler using custom params. |name| is used to
// label threads and histograms. It should identify the component that creates
// the TaskScheduler. |init_params| is used to initialize the worker pools.
« no previous file with comments | « base/task_scheduler/scheduler_worker_pool_impl.cc ('k') | base/task_scheduler/task_scheduler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698