Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionStatsPreference.java

Issue 2809123003: Fix graph labels on Data Saver settings page for RTL (Closed)
Patch Set: twellington comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/res/layout/data_reduction_stats_layout.xml ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionStatsPreference.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionStatsPreference.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionStatsPreference.java
index 4c3f1775c42675745b1e7cf2a21d66435abfdc22..77cfb84f841cd73dee46a1901b7ac1d0252404d5 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionStatsPreference.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionStatsPreference.java
@@ -15,9 +15,11 @@ import android.preference.Preference;
import android.text.format.DateUtils;
import android.text.format.Formatter;
import android.util.AttributeSet;
+import android.view.Gravity;
import android.view.View;
import android.view.View.OnClickListener;
import android.widget.Button;
+import android.widget.FrameLayout;
import android.widget.TextView;
import org.chromium.base.Callback;
@@ -127,6 +129,15 @@ public class DataReductionStatsPreference extends Preference {
}
/**
+ * Keep the graph labels LTR oriented. In RTL languages, numbers and plots remain LTR.
+ */
+ @SuppressLint("RtlHardcoded")
+ private void forceLayoutGravityOfGraphLabels() {
+ ((FrameLayout.LayoutParams) mStartDateTextView.getLayoutParams()).gravity = Gravity.LEFT;
+ ((FrameLayout.LayoutParams) mEndDateTextView.getLayoutParams()).gravity = Gravity.RIGHT;
+ }
+
+ /**
* Sets up a data usage chart and text views containing data reduction statistics.
* @param view The current view.
*/
@@ -142,6 +153,7 @@ public class DataReductionStatsPreference extends Preference {
mEndDateTextView = (TextView) view.findViewById(R.id.data_reduction_end_date);
mDataReductionBreakdownView =
(DataReductionSiteBreakdownView) view.findViewById(R.id.breakdown);
+ forceLayoutGravityOfGraphLabels();
updateReductionStatistics();
setDetailText();
« no previous file with comments | « chrome/android/java/res/layout/data_reduction_stats_layout.xml ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698