Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Unified Diff: ash/wm/ash_focus_rules.cc

Issue 2809073002: cros: allow aura window not considered activatable for pointer event (Closed)
Patch Set: rebase and fix conflicts Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/wm/ash_focus_rules.cc
diff --git a/ash/wm/ash_focus_rules.cc b/ash/wm/ash_focus_rules.cc
index ac4d9a8d5632563c6275db5b47a2fa061bc2e870..ba9cbcd8027333907ecd80cc59cb6b6257c64711 100644
--- a/ash/wm/ash_focus_rules.cc
+++ b/ash/wm/ash_focus_rules.cc
@@ -13,7 +13,9 @@
#include "ash/wm/window_state.h"
#include "ash/wm/window_state_aura.h"
#include "ash/wm_window.h"
+#include "ui/aura/client/aura_constants.h"
#include "ui/aura/window.h"
+#include "ui/events/event.h"
namespace ash {
namespace wm {
@@ -33,13 +35,9 @@ bool BelongsToContainerWithEqualOrGreaterId(const aura::Window* window,
////////////////////////////////////////////////////////////////////////////////
// AshFocusRules, public:
-AshFocusRules::AshFocusRules() {}
+AshFocusRules::AshFocusRules() = default;
-AshFocusRules::~AshFocusRules() {}
-
-bool AshFocusRules::IsWindowConsideredActivatable(aura::Window* window) const {
- return ash::IsWindowConsideredActivatable(WmWindow::Get(window));
-}
+AshFocusRules::~AshFocusRules() = default;
////////////////////////////////////////////////////////////////////////////////
// AshFocusRules, ::wm::FocusRules:
@@ -73,6 +71,18 @@ bool AshFocusRules::CanActivateWindow(aura::Window* window) const {
return true;
}
+bool AshFocusRules::IsWindowConsideredActivatableForEvent(
+ aura::Window* window,
+ ui::Event* event) const {
+ if (!window)
+ return true;
+
+ if (event->IsMouseEvent())
+ return window->GetProperty(aura::client::kActivateOnClickKey);
+
+ return true;
+}
+
aura::Window* AshFocusRules::GetNextActivatableWindow(
aura::Window* ignore) const {
DCHECK(ignore);
@@ -141,7 +151,7 @@ aura::Window* AshFocusRules::GetTopmostWindowToActivateInContainer(
!window_state->IsMinimized())
return *i;
}
- return NULL;
+ return nullptr;
}
} // namespace wm

Powered by Google App Engine
This is Rietveld 408576698