components/prefs/pref_member.cc - Issue 2809023003: Reland of Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/prefs/pref_member.cc

Issue 2809023003: Reland of Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/prefs/pref_member.cc

diff --git a/components/prefs/pref_member.cc b/components/prefs/pref_member.cc

index 8ed13ee5516769d8d6bae89089c9ab9115a4667f..f0be267ed5d360d4137bc356127a2f2f26cd7065 100644

--- a/components/prefs/pref_member.cc

+++ b/components/prefs/pref_member.cc

@@ -139,7 +139,7 @@ bool PrefMemberVectorStringUpdate(const base::Value& value,

for (base::ListValue::const_iterator it = list->begin();

it != list->end(); ++it) {

std::string string_value;

- if (!(*it)->GetAsString(&string_value))

+ if (!it->GetAsString(&string_value))

return false;

local_vector.push_back(string_value);