chrome/browser/ui/webui/options/chromeos/display_options_handler.cc - Issue 2809023003: Reland of Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/chromeos/display_options_handler.cc

Issue 2809023003: Reland of Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc ('k') | chrome/browser/ui/webui/options/content_settings_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/chromeos/display_options_handler.cc

diff --git a/chrome/browser/ui/webui/options/chromeos/display_options_handler.cc b/chrome/browser/ui/webui/options/chromeos/display_options_handler.cc

index f6348dded3089dd90567f10a1b331200f3676904..4ea500a53eead1f346aacc8c8c58ca38cf170927 100644

--- a/chrome/browser/ui/webui/options/chromeos/display_options_handler.cc

+++ b/chrome/browser/ui/webui/options/chromeos/display_options_handler.cc

@@ -434,7 +434,7 @@ void DisplayOptionsHandler::HandleSetDisplayLayout(

builder.ClearPlacements();

for (const auto& layout : *layouts) {

const base::DictionaryValue* dictionary;

- if (!layout->GetAsDictionary(&dictionary)) {

+ if (!layout.GetAsDictionary(&dictionary)) {

LOG(ERROR) << "Invalid layout dictionary: " << *dictionary;

continue;

}