chrome/browser/printing/cloud_print/cloud_print_printer_list.cc - Issue 2809023003: Reland of Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/cloud_print/cloud_print_printer_list.cc

Issue 2809023003: Reland of Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/printing/cloud_print/cloud_print_printer_list.cc

diff --git a/chrome/browser/printing/cloud_print/cloud_print_printer_list.cc b/chrome/browser/printing/cloud_print/cloud_print_printer_list.cc

index d826da16d2e45c9d44ea588be6b8b025e27022a5..3e12b0ecf2592b040cc8902bb80af7184d30226a 100644

--- a/chrome/browser/printing/cloud_print/cloud_print_printer_list.cc

+++ b/chrome/browser/printing/cloud_print/cloud_print_printer_list.cc

@@ -32,8 +32,8 @@ void CloudPrintPrinterList::OnGCDApiFlowComplete(

DeviceList devices;

for (const auto& printer : *printers) {

- base::DictionaryValue* printer_dict;

- if (!printer->GetAsDictionary(&printer_dict))

+ const base::DictionaryValue* printer_dict;

+ if (!printer.GetAsDictionary(&printer_dict))

continue;

Device printer_details;