chrome/browser/media/chromeos_login_media_access_handler.cc - Issue 2809023003: Reland of Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/chromeos_login_media_access_handler.cc

Issue 2809023003: Reland of Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/media/chromeos_login_media_access_handler.cc

diff --git a/chrome/browser/media/chromeos_login_media_access_handler.cc b/chrome/browser/media/chromeos_login_media_access_handler.cc

index 0b79c9707b089c57aa756fac456ae92736311886..e413fdae407ee6020c1cf2396f6091cb0c0001ba 100644

--- a/chrome/browser/media/chromeos_login_media_access_handler.cc

+++ b/chrome/browser/media/chromeos_login_media_access_handler.cc

@@ -63,7 +63,7 @@ bool ChromeOSLoginMediaAccessHandler::CheckMediaAccessPermission(

DCHECK(is_list);

for (const auto& base_value : *list_value) {

std::string value;

- if (base_value->GetAsString(&value)) {

+ if (base_value.GetAsString(&value)) {

const ContentSettingsPattern pattern =

ContentSettingsPattern::FromString(value);

// Force administrators to specify more-specific patterns by ignoring the