Reland of Change base::Value::ListStorage to std::vector<base::Value>

ui/app_list/search/history_data_store.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/app_list/search/history_data_store.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <utility>
@@ skipping 17 matching lines @@
 const char kKeySecondary[] = "s";
 const char kKeyUpdateTime[] = "t";
 
 // Extracts strings from ListValue.
 void GetSecondary(const base::ListValue* list,
                   HistoryData::SecondaryDeque* secondary) {
   HistoryData::SecondaryDeque results;
   for (base::ListValue::const_iterator it = list->begin(); it != list->end();
        ++it) {
     std::string str;
-    if (!(*it)->GetAsString(&str))
+    if (!it->GetAsString(&str))
       return;
 
     results.push_back(str);
   }
 
   secondary->swap(results);
 }
 
 // V1 format json dictionary:
 //  {
@@ skipping 167 matching lines @@
     OnLoadedCallback callback,
     std::unique_ptr<base::DictionaryValue> dict) {
   if (!dict) {
     callback.Run(nullptr);
   } else {
     callback.Run(Parse(std::move(dict)));
   }
 }
 
 }  // namespace app_list