Reland of Change base::Value::ListStorage to std::vector<base::Value>

extensions/common/manifest_handlers/requirements_info.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/common/manifest_handlers/requirements_info.h"
 
 #include <memory>
 
 #include "base/lazy_instance.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 99 matching lines @@
                                                           &features) ||
           !features) {
         *error = ErrorUtils::FormatErrorMessageUTF16(
             errors::kInvalidRequirement, iter.key());
         return false;
       }
 
       for (base::ListValue::const_iterator feature_iter = features->begin();
            feature_iter != features->end(); ++feature_iter) {
         std::string feature;
-        if ((*feature_iter)->GetAsString(&feature)) {
+        if (feature_iter->GetAsString(&feature)) {
           if (feature == "webgl") {
             requirements->webgl = true;
           } else if (feature == "css3d") {
             // css3d is always available, so no check is needed, but no error is
             // generated.
           } else {
             *error = ErrorUtils::FormatErrorMessageUTF16(
                 errors::kInvalidRequirement, iter.key());
             return false;
           }
@@ skipping 20 matching lines @@
       *error = base::ASCIIToUTF16(errors::kInvalidRequirements);
       return false;
     }
   }
 
   extension->SetManifestData(keys::kRequirements, std::move(requirements));
   return true;
 }
 
 }  // namespace extensions