Reland of Change base::Value::ListStorage to std::vector<base::Value>

components/ntp_snippets/remote/remote_suggestion.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/ntp_snippets/remote/remote_suggestion.h"
 
 #include "base/feature_list.h"
 #include "base/memory/ptr_util.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/stringprintf.h"
@@ skipping 101 matching lines @@
   const base::ListValue* corpus_infos_list = nullptr;
   if (!content->GetList("sourceCorpusInfo", &corpus_infos_list)) {
     DLOG(WARNING) << "No sources found for article " << primary_id;
     return nullptr;
   }
 
   std::vector<std::string> ids(1, primary_id);
   std::vector<SnippetSource> sources;
   for (const auto& value : *corpus_infos_list) {
     const base::DictionaryValue* dict_value = nullptr;
-    if (!value->GetAsDictionary(&dict_value)) {
+    if (!value.GetAsDictionary(&dict_value)) {
       DLOG(WARNING) << "Invalid source info for article " << primary_id;
       continue;
     }
 
     std::string corpus_id_str;
     GURL corpus_id;
     if (dict_value->GetString("corpusId", &corpus_id_str)) {
       corpus_id = GURL(corpus_id_str);
     }
 
@@ skipping 88 matching lines @@
     const base::DictionaryValue& dict,
     int remote_category_id,
     const base::Time& fetch_date) {
   const base::ListValue* ids;
   if (!dict.GetList("ids", &ids)) {
     return nullptr;
   }
   std::vector<std::string> parsed_ids;
   for (const auto& value : *ids) {
     std::string id;
-    if (!value->GetAsString(&id)) {
+    if (!value.GetAsString(&id)) {
       return nullptr;
     }
     parsed_ids.push_back(id);
   }
 
   if (parsed_ids.empty()) {
     return nullptr;
   }
   auto snippet = MakeUnique(parsed_ids, remote_category_id);
   snippet->fetch_date_ = fetch_date;
@@ skipping 186 matching lines @@
 }
 
 // static
 std::unique_ptr<RemoteSuggestion> RemoteSuggestion::MakeUnique(
     const std::vector<std::string>& ids,
     int remote_category_id) {
   return base::WrapUnique(new RemoteSuggestion(ids, remote_category_id));
 }
 
 }  // namespace ntp_snippets