Reland of Change base::Value::ListStorage to std::vector<base::Value>

chromecast/crash/linux/crash_testing_utils.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromecast/crash/linux/crash_testing_utils.h"
 
 #include <utility>
 
 #include "base/files/file_util.h"
 #include "base/memory/ptr_util.h"
@@ skipping 45 matching lines @@
 
 std::unique_ptr<base::Value> ParseMetadataFile(const std::string& path) {
   return DeserializeJsonFromFile(base::FilePath(path));
 }
 
 int WriteLockFile(const std::string& path, base::ListValue* contents) {
   DCHECK(contents);
   std::string lockfile;
 
   for (const auto& elem : *contents) {
-    std::unique_ptr<std::string> dump_info = SerializeToJson(*elem);
+    std::unique_ptr<std::string> dump_info = SerializeToJson(elem);
     RCHECK(dump_info, -1, "Failed to serialize DumpInfo");
     lockfile += *dump_info;
     lockfile += "\n";  // Add line seperatators
   }
 
   return WriteFile(base::FilePath(path), lockfile.c_str(), lockfile.size()) >= 0
              ? 0
              : -1;
 }
 
@@ skipping 11 matching lines @@
 
 bool FetchDumps(const std::string& lockfile_path,
                 std::vector<std::unique_ptr<DumpInfo>>* dumps) {
   DCHECK(dumps);
   std::unique_ptr<base::ListValue> dump_list = ParseLockFile(lockfile_path);
   RCHECK(dump_list, false, "Failed to parse lockfile");
 
   dumps->clear();
 
   for (const auto& elem : *dump_list) {
-    std::unique_ptr<DumpInfo> dump(new DumpInfo(elem.get()));
+    std::unique_ptr<DumpInfo> dump(new DumpInfo(&elem));
     RCHECK(dump->valid(), false, "Invalid DumpInfo");
     dumps->push_back(std::move(dump));
   }
 
   return true;
 }
 
 bool ClearDumps(const std::string& lockfile_path) {
   std::unique_ptr<base::ListValue> dump_list =
       base::MakeUnique<base::ListValue>();
@@ skipping 41 matching lines @@
   if (!contents || !contents->GetAsDictionary(&dict) ||
       !dict->GetDictionary(kRatelimitKey, &ratelimit_params)) {
     return false;
   }
 
   ratelimit_params->SetDouble(kRatelimitPeriodStartKey, start.ToDoubleT());
   return WriteMetadataFile(metadata_path, contents.get()) == 0;
 }
 
 }  // namespace chromecast