Reland of Change base::Value::ListStorage to std::vector<base::Value>

chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.h"
 
 #include <stddef.h>
 #include <string>
 #include <utility>
 
@@ skipping 80 matching lines @@
 // needed by the UI to properly display the Accounts page.
 base::Value* CreateUsersWhitelist(const base::Value *pref_value) {
   const base::ListValue* list_value =
       static_cast<const base::ListValue*>(pref_value);
   base::ListValue* user_list = new base::ListValue();
   user_manager::UserManager* user_manager = user_manager::UserManager::Get();
 
   for (base::ListValue::const_iterator i = list_value->begin();
        i != list_value->end(); ++i) {
     std::string email;
-    if ((*i)->GetAsString(&email)) {
+    if (i->GetAsString(&email)) {
       // Translate email to the display email.
       const std::string display_email =
           user_manager->GetUserDisplayEmail(AccountId::FromUserEmail(email));
       // TODO(ivankr): fetch display name for existing users.
       user_list->Append(CreateUserInfo(email, display_email, std::string()));
     }
   }
   return user_list;
 }
 
@@ skipping 305 matching lines @@
         GetUiProxyConfigService(), &value);
     DCHECK(value);
     std::unique_ptr<base::Value> ptr(value);
     DispatchPrefChangeNotification(
         proxy_cros_settings_parser::kProxySettings[i], std::move(ptr));
   }
 }
 
 }  // namespace options
 }  // namespace chromeos