Reland of Change base::Value::ListStorage to std::vector<base::Value>

chrome/browser/net/predictor_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/net/predictor.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <memory>
@@ skipping 88 matching lines @@
       FindSerializationMotivation(motivation, referral_list);
   if (!motivation_list) {
     // This is the first mention of this motivation, so build a list.
     motivation_list = new base::ListValue;
     motivation_list->AppendString(motivation.spec());
     // Provide empty subresource list.
     motivation_list->Append(base::MakeUnique<base::ListValue>());
 
     // ...and make it part of the serialized referral_list.
     referral_list->Append(base::WrapUnique(motivation_list));
+    // |motivation_list| is invalidated at this point, so it needs to be reset.
+    referral_list->GetList(referral_list->GetSize() - 1, &motivation_list);
   }
 
   base::ListValue* subresource_list(NULL);
   // 0 == url; 1 == subresource_list.
   EXPECT_TRUE(motivation_list->GetList(1, &subresource_list));
 
   // We won't bother to check for the subresource being there already.  Worst
   // case, during deserialization, the latency value we supply plus the
   // existing value(s) will be added to the referrer.
 
@@ skipping 441 matching lines @@
   testing_master.Resolve(goog, UrlInfo::OMNIBOX_MOTIVATED);
 
   // Proxy may not be in use (the PAC script has not yet been evaluated), so the
   // name has been registered for pre-resolve.
   EXPECT_FALSE(testing_master.work_queue_.IsEmpty());
 
   testing_master.Shutdown();
 }
 
 }  // namespace chrome_browser_net