Reland of Change base::Value::ListStorage to std::vector<base::Value>

chrome/browser/extensions/api/identity/identity_apitest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <set>
 #include <string>
 #include <utility>
 #include <vector>
 
 #include "base/command_line.h"
@@ skipping 404 matching lines @@
 
     const base::ListValue* results;
     if (!callback_arguments->GetList(0, &results))
       GenerateFailureResult(accounts, NULL) << "Result was not an array";
 
     std::set<std::string> result_ids;
     for (base::ListValue::const_iterator it = results->begin();
          it != results->end();
          ++it) {
       std::unique_ptr<api::identity::AccountInfo> info =
-          api::identity::AccountInfo::FromValue(**it);
+          api::identity::AccountInfo::FromValue(*it);
       if (info.get())
         result_ids.insert(info->id);
       else
         return GenerateFailureResult(accounts, results);
     }
 
     for (std::vector<std::string>::const_iterator it = accounts.begin();
          it != accounts.end();
          ++it) {
       if (result_ids.find(*it) == result_ids.end())
@@ skipping 11 matching lines @@
          it != accounts.end();
          ++it) {
       msg << *it << " ";
     }
     msg << "Actual: ";
     if (!results) {
       msg << "NULL";
     } else {
       for (const auto& result : *results) {
         std::unique_ptr<api::identity::AccountInfo> info =
-            api::identity::AccountInfo::FromValue(*result);
+            api::identity::AccountInfo::FromValue(result);
         if (info.get())
           msg << info->id << " ";
         else
-          msg << *result << "<-" << result->GetType() << " ";
+          msg << result << "<-" << result.GetType() << " ";
       }
     }
 
     return testing::AssertionFailure(msg);
   }
 };
 
 IN_PROC_BROWSER_TEST_F(IdentityGetAccountsFunctionTest, MultiAccountOn) {
   EXPECT_TRUE(switches::IsExtensionsMultiAccount());
 }
@@ skipping 1386 matching lines @@
   EXPECT_EQ(std::string("https://abcdefghij.chromiumapp.org/callback#test"),
             url);
 }
 
 }  // namespace extensions
 
 // Tests the chrome.identity API implemented by custom JS bindings .
 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, ChromeIdentityJsBindings) {
   ASSERT_TRUE(RunExtensionTest("identity/js_bindings")) << message_;
 }