Reland of Change base::Value::ListStorage to std::vector<base::Value>

chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file tests the chromeos.quickUnlockPrivate extension API.
 
 #include "chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api.h"
 
 #include <algorithm>
 
@@ skipping 96 matching lines @@
     // Run the function.
     std::unique_ptr<base::Value> result =
         RunFunction(new QuickUnlockPrivateGetAvailableModesFunction(),
                     base::MakeUnique<base::ListValue>());
 
     // Extract the results.
     QuickUnlockModeList modes;
 
     base::ListValue* list = nullptr;
     EXPECT_TRUE(result->GetAsList(&list));
-    // Consume the unique_ptr by reference so we don't take ownership.
-    for (const std::unique_ptr<base::Value>& value : (*list)) {
+    for (const base::Value& value : *list) {
       std::string mode;
-      EXPECT_TRUE(value->GetAsString(&mode));
+      EXPECT_TRUE(value.GetAsString(&mode));
       modes.push_back(quick_unlock_private::ParseQuickUnlockMode(mode));
     }
 
     return modes;
   }
 
   // Wrapper for chrome.quickUnlockPrivate.getActiveModes.
   QuickUnlockModeList GetActiveModes() {
     std::unique_ptr<base::Value> result =
         RunFunction(new QuickUnlockPrivateGetActiveModesFunction(),
                     base::MakeUnique<base::ListValue>());
 
     QuickUnlockModeList modes;
 
     base::ListValue* list = nullptr;
     EXPECT_TRUE(result->GetAsList(&list));
-    for (const std::unique_ptr<base::Value>& value : *list) {
+    for (const base::Value& value : *list) {
       std::string mode;
-      EXPECT_TRUE(value->GetAsString(&mode));
+      EXPECT_TRUE(value.GetAsString(&mode));
       modes.push_back(quick_unlock_private::ParseQuickUnlockMode(mode));
     }
 
     return modes;
   }
 
   // Returns true if |problem| is contained in |problems|.
   bool HasProblem(CredentialProblem problem,
                   const std::vector<CredentialProblem> problems) {
     return std::find(problems.begin(), problems.end(), problem) !=
@@ skipping 335 matching lines @@
   // length pref.
   pref_service->SetInteger(prefs::kPinUnlockMaximumLength, 4);
   CheckGetCredentialRequirements(6, 6);
 
   // Verify that the values received from policy are sanitized.
   pref_service->SetInteger(prefs::kPinUnlockMinimumLength, -3);
   pref_service->SetInteger(prefs::kPinUnlockMaximumLength, -3);
   CheckGetCredentialRequirements(1, 0);
 }
 }  // namespace chromeos