third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackFunctions.cpp - Issue 2809003004: bindings: Use ExceptionMessages when an interface/callback conversion fails.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackFunctions.cpp

Issue 2809003004: bindings: Use ExceptionMessages when an interface/callback conversion fails. (Closed)

Patch Set: Add ExceptionMessages::FailedToConvertJSValue Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/tests/results/core/V8SVGTestInterface.cpp ('k') | third_party/WebKit/Source/bindings/tests/results/core/V8TestConstants.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackFunctions.cpp

diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackFunctions.cpp b/third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackFunctions.cpp

index f2664b09ec8b7a46bd50a4264d12e048ff4094f4..10a3fc84f075923bd027070088464ec867e37e05 100644

--- a/third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackFunctions.cpp

+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackFunctions.cpp

@@ -336,8 +336,10 @@ TestCallbackFunctions* V8TestCallbackFunctions::toImplWithTypeCheck(v8::Isolate*

TestCallbackFunctions* NativeValueTraits<TestCallbackFunctions>::NativeValue(v8::Isolate* isolate, v8::Local<v8::Value> value, ExceptionState& exceptionState) {

TestCallbackFunctions* nativeValue = V8TestCallbackFunctions::toImplWithTypeCheck(isolate, value);

- if (!nativeValue)

- exceptionState.ThrowTypeError("Unable to convert value to TestCallbackFunctions.");

+ if (!nativeValue) {

+ exceptionState.ThrowTypeError(ExceptionMessages::FailedToConvertJSValue(

+ "TestCallbackFunctions"));

+ }

return nativeValue;

}