Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: third_party/WebKit/Source/bindings/core/v8/ExceptionMessages.h

Issue 2809003004: bindings: Use ExceptionMessages when an interface/callback conversion fails. (Closed)
Patch Set: Add ExceptionMessages::FailedToConvertJSValue Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/ExceptionMessages.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 public: 47 public:
48 enum BoundType { 48 enum BoundType {
49 kInclusiveBound, 49 kInclusiveBound,
50 kExclusiveBound, 50 kExclusiveBound,
51 }; 51 };
52 52
53 static String ArgumentNullOrIncorrectType(int argument_index, 53 static String ArgumentNullOrIncorrectType(int argument_index,
54 const String& expected_type); 54 const String& expected_type);
55 static String ConstructorNotCallableAsFunction(const char* type); 55 static String ConstructorNotCallableAsFunction(const char* type);
56 56
57 static String FailedToConvertJSValue(const char* type);
58
57 static String FailedToConstruct(const char* type, const String& detail); 59 static String FailedToConstruct(const char* type, const String& detail);
58 static String FailedToEnumerate(const char* type, const String& detail); 60 static String FailedToEnumerate(const char* type, const String& detail);
59 static String FailedToExecute(const char* method, 61 static String FailedToExecute(const char* method,
60 const char* type, 62 const char* type,
61 const String& detail); 63 const String& detail);
62 static String FailedToGet(const char* property, 64 static String FailedToGet(const char* property,
63 const char* type, 65 const char* type,
64 const String& detail); 66 const String& detail);
65 static String FailedToSet(const char* property, 67 static String FailedToSet(const char* property,
66 const char* type, 68 const char* type,
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
176 }; 178 };
177 179
178 template <> 180 template <>
179 String ExceptionMessages::FormatNumber<float>(float number); 181 String ExceptionMessages::FormatNumber<float>(float number);
180 template <> 182 template <>
181 String ExceptionMessages::FormatNumber<double>(double number); 183 String ExceptionMessages::FormatNumber<double>(double number);
182 184
183 } // namespace blink 185 } // namespace blink
184 186
185 #endif // ExceptionMessages_h 187 #endif // ExceptionMessages_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/ExceptionMessages.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698