Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/app/bookmarks_strings.grdp

Issue 2809003002: Making bookmark folder context menu display the number of bookmarks that will be opened by Open All (Closed)
Patch Set: All changes to add count to context menu Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/bookmarks/bookmark_context_menu_controller.h » ('j') | chrome/browser/ui/bookmarks/bookmark_context_menu_controller.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/app/bookmarks_strings.grdp
diff --git a/chrome/app/bookmarks_strings.grdp b/chrome/app/bookmarks_strings.grdp
index 52fd6de071c3beeaefe10224be0f7e4f9397da22..5c55cf1c19312810fe5446ec9e0afc549c731704 100644
--- a/chrome/app/bookmarks_strings.grdp
+++ b/chrome/app/bookmarks_strings.grdp
@@ -63,15 +63,24 @@
<!-- Begin of Bookmarks Bar Context Menu strings. -->
<if expr="not use_titlecase">
- <message name="IDS_BOOKMARK_BAR_OPEN_ALL" desc="Menu title for opening all urls in a bookmark folder">
- &amp;Open all bookmarks
- </message>
- <message name="IDS_BOOKMARK_BAR_OPEN_ALL_NEW_WINDOW" desc="Menu title for opening all urls in a bookmark folder in a new window">
- Open all bookmarks in &amp;new window
- </message>
- <message name="IDS_BOOKMARK_BAR_OPEN_ALL_INCOGNITO" desc="Menu description for opening all urls in a bookmark folder in an incognito window">
- Open all bookmarks in &amp;incognito window
- </message>
+ <message name="IDS_BOOKMARK_BAR_OPEN_ALL" desc="Menu title for opening all urls in a bookmark folder">
Peter Kasting 2017/04/13 04:52:09 Please set your editor to add spaces, not tabs, an
Paezagon 2017/04/14 01:00:29 Missed that. The git cl format corrected all the o
+ {COUNT, plural,
+ =0 {&amp;Open all}
Peter Kasting 2017/04/13 04:52:08 Is this only displayed as a disabled menu item?
Paezagon 2017/04/14 01:00:29 As far as I can tell, yes.
+ =1 {&amp;Open bookmark}
+ other {&amp;Open all (#)}}
+ </message>
+ <message name="IDS_BOOKMARK_BAR_OPEN_ALL_NEW_WINDOW" desc="Menu title for opening all urls in a bookmark folder in a new window">
+ {COUNT, plural,
+ =0 {Open all in &amp;new window}
+ =1 {Open in &amp;new window}
+ other {Open all (#) in &amp;new window}}
+ </message>
+ <message name="IDS_BOOKMARK_BAR_OPEN_ALL_INCOGNITO" desc="Menu description for opening all urls in a bookmark folder in an incognito window">
+ {COUNT, plural,
+ =0 {Open all in &amp;incognito window}
+ =1 {Open in &amp;incognito window}
+ other {Open all (#) in &amp;incognito window}}
+ </message>
<message name="IDS_BOOKMARK_BAR_OPEN_IN_NEW_TAB" desc="Menu description for loading bookmark in a new tab">
&amp;Open in new tab
</message>
@@ -103,15 +112,24 @@
</if>
</if>
<if expr="use_titlecase">
- <message name="IDS_BOOKMARK_BAR_OPEN_ALL" desc="In Title Case: Menu title for opening all urls in a bookmark folder">
- &amp;Open All Bookmarks
- </message>
- <message name="IDS_BOOKMARK_BAR_OPEN_ALL_NEW_WINDOW" desc="In Title Case: Menu title for opening all urls in a bookmark folder in a new window">
- Open All Bookmarks in &amp;New Window
- </message>
- <message name="IDS_BOOKMARK_BAR_OPEN_ALL_INCOGNITO" desc="In Title Case: Menu description for opening all urls in a bookmark folder in an incognito window">
- Open All Bookmarks in &amp;Incognito Window
- </message>
+ <message name="IDS_BOOKMARK_BAR_OPEN_ALL" desc="In Title Case: Menu title for opening all urls in a bookmark folder">
+ {COUNT, plural,
+ =0 {&amp;Open All}
+ =1 {&amp;Open Bookmark}
+ other {&amp;Open All (#)}}
+ </message>
+ <message name="IDS_BOOKMARK_BAR_OPEN_ALL_NEW_WINDOW" desc="In Title Case: Menu title for opening all urls in a bookmark folder in a new window">
+ {COUNT, plural,
+ =0 {Open All in &amp;New Window}
+ =1 {Open in &amp;New Window}
+ other {Open All (#) in &amp;New Window}}
+ </message>
+ <message name="IDS_BOOKMARK_BAR_OPEN_ALL_INCOGNITO" desc="In Title Case: Menu description for opening all urls in a bookmark folder in an incognito window">
+ {COUNT, plural,
+ =0 {Open All in &amp;Incognito Window}
+ =1 {Open in &amp;Incognito Window}
+ other {Open All (#) in &amp;Incognito Window}}
+ </message>
<message name="IDS_BOOKMARK_BAR_OPEN_IN_NEW_TAB" desc="In Title Case: Menu description for loading bookmark in a new tab">
&amp;Open in New Tab
</message>
« no previous file with comments | « no previous file | chrome/browser/ui/bookmarks/bookmark_context_menu_controller.h » ('j') | chrome/browser/ui/bookmarks/bookmark_context_menu_controller.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698