Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3034)

Unified Diff: chrome/browser/ui/bookmarks/bookmark_context_menu_controller.cc

Issue 2809003002: Making bookmark folder context menu display the number of bookmarks that will be opened by Open All (Closed)
Patch Set: Fixing compilation issues Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/bookmarks/bookmark_context_menu_controller.cc
diff --git a/chrome/browser/ui/bookmarks/bookmark_context_menu_controller.cc b/chrome/browser/ui/bookmarks/bookmark_context_menu_controller.cc
index c458e03c0829524481653ee95958a0244c6b8b22..f7362408987b0f67bf96a04d8825b76e847ee74b 100644
--- a/chrome/browser/ui/bookmarks/bookmark_context_menu_controller.cc
+++ b/chrome/browser/ui/bookmarks/bookmark_context_menu_controller.cc
@@ -77,11 +77,18 @@ void BookmarkContextMenuController::BuildMenu() {
AddItem(IDC_BOOKMARK_BAR_OPEN_ALL_INCOGNITO,
IDS_BOOKMARK_BAR_OPEN_INCOGNITO);
} else {
- AddItem(IDC_BOOKMARK_BAR_OPEN_ALL, IDS_BOOKMARK_BAR_OPEN_ALL);
+ int count = chrome::OpenCount(parent_window_, selection_);
+ AddItem(IDC_BOOKMARK_BAR_OPEN_ALL,
+ l10n_util::GetPluralStringFUTF16(IDS_BOOKMARK_BAR_OPEN_ALL, count));
AddItem(IDC_BOOKMARK_BAR_OPEN_ALL_NEW_WINDOW,
- IDS_BOOKMARK_BAR_OPEN_ALL_NEW_WINDOW);
+ l10n_util::GetPluralStringFUTF16(
+ IDS_BOOKMARK_BAR_OPEN_ALL_NEW_WINDOW, count));
+
+ int incognito_count =
+ chrome::OpenCount(parent_window_, selection_, profile_);
AddItem(IDC_BOOKMARK_BAR_OPEN_ALL_INCOGNITO,
- IDS_BOOKMARK_BAR_OPEN_ALL_INCOGNITO);
+ l10n_util::GetPluralStringFUTF16(
+ IDS_BOOKMARK_BAR_OPEN_ALL_INCOGNITO, incognito_count));
}
AddSeparator();
@@ -120,6 +127,10 @@ void BookmarkContextMenuController::BuildMenu() {
AddCheckboxItem(IDC_BOOKMARK_BAR_ALWAYS_SHOW, IDS_SHOW_BOOKMARK_BAR);
}
+void BookmarkContextMenuController::AddItem(int id, const base::string16 str) {
+ menu_model_->AddItem(id, str);
+}
+
void BookmarkContextMenuController::AddItem(int id, int localization_id) {
menu_model_->AddItemWithStringId(id, localization_id);
}
@@ -391,7 +402,7 @@ bool BookmarkContextMenuController::IsCommandIdEnabled(int command_id) const {
case IDC_BOOKMARK_BAR_NEW_FOLDER:
case IDC_BOOKMARK_BAR_ADD_NEW_BOOKMARK:
return can_edit && model_->client()->CanBeEditedByUser(parent_) &&
- bookmarks::GetParentForNewNodes(parent_, selection_, NULL) != NULL;
+ bookmarks::GetParentForNewNodes(parent_, selection_, nullptr);
case IDC_BOOKMARK_BAR_ALWAYS_SHOW:
return !prefs->IsManagedPreference(bookmarks::prefs::kShowBookmarkBar);
« no previous file with comments | « chrome/browser/ui/bookmarks/bookmark_context_menu_controller.h ('k') | chrome/browser/ui/bookmarks/bookmark_utils_desktop.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698