Making bookmark folder context menu display the number of bookmarks that will be opened by Open All

chrome/browser/ui/views/bookmarks/bookmark_context_menu_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/bookmarks/bookmark_context_menu.h"
 
 #include <stddef.h>
 
 #include <memory>
 #include <string>
@@ skipping 134 matching lines @@
 TEST_F(BookmarkContextMenuTest, OpenAllIncognito) {
   const BookmarkNode* folder = model_->bookmark_bar_node()->GetChild(1);
   chrome::OpenAll(NULL, &navigator_, folder,
                   WindowOpenDisposition::OFF_THE_RECORD, profile_.get());
 
   // Should have navigated to only f1a but not f2a.
   ASSERT_EQ(static_cast<size_t>(1), navigator_.urls_.size());
   ASSERT_TRUE(folder->GetChild(0)->url() == navigator_.urls_[0]);
 }
 
+// Tests counting tabs for 'open all' on a folder with a couple of bookmarks.
+TEST_F(BookmarkContextMenuTest, OpenCount) {
+  const BookmarkNode* folder = model_->bookmark_bar_node()->GetChild(1);
+  int result = chrome::OpenCount(NULL, folder);
+
+  // Should have navigated to F1's child but not F11's child.

[Peter Kasting, 2017/04/14 08:17:15]

Nit: Should have navigated -> OpenAll() would navigate (2 places)

[Paezagon, 2017/04/14 18:47:25]

Done.

+  ASSERT_EQ(static_cast<size_t>(2), result);

[Peter Kasting, 2017/04/14 08:17:15]

Nit: Can be EXPECT rather than ASSERT.  Use "2U" instead of static casting. (2
places)

[Paezagon, 2017/04/14 18:47:25]

Done.

+}
+
+// Tests counting on 'open all' on a folder with a couple of bookmarks in
+// incognito window.

[Peter Kasting, 2017/04/14 08:17:15]

Nit: This is slightly unclear; maybe instead "Same as the above test, but for
bookmarks openable in incognito mode."

[Paezagon, 2017/04/14 18:47:24]

Done.

+TEST_F(BookmarkContextMenuTest, OpenCountIncognito) {
+  const BookmarkNode* folder = model_->bookmark_bar_node()->GetChild(1);
+  int result = chrome::OpenCount(NULL, folder, true, profile_.get());
+
+  // Should have navigated to only f1a but not f2a.
+  ASSERT_EQ(static_cast<size_t>(1), result);
+}
+
 // Tests the enabled state of the menus when supplied an empty vector.
 TEST_F(BookmarkContextMenuTest, EmptyNodes) {
   BookmarkContextMenu controller(
       NULL, NULL, profile_.get(), NULL, model_->other_node(),
       std::vector<const BookmarkNode*>(), false);
   EXPECT_FALSE(controller.IsCommandEnabled(IDC_BOOKMARK_BAR_OPEN_ALL));
   EXPECT_FALSE(
       controller.IsCommandEnabled(IDC_BOOKMARK_BAR_OPEN_ALL_NEW_WINDOW));
   EXPECT_FALSE(
       controller.IsCommandEnabled(IDC_BOOKMARK_BAR_OPEN_ALL_INCOGNITO));
@@ skipping 209 matching lines @@
   controller.reset(new BookmarkContextMenu(
       NULL, NULL, profile_.get(), NULL, nodes[0]->parent(), nodes, false));
   EXPECT_TRUE(controller->IsCommandVisible(IDC_BOOKMARK_BAR_NEW_FOLDER));
   EXPECT_TRUE(
       controller->IsCommandVisible(IDC_BOOKMARK_BAR_SHOW_MANAGED_BOOKMARKS));
   menu = controller->menu();
   EXPECT_TRUE(menu->GetMenuItemByID(IDC_BOOKMARK_BAR_NEW_FOLDER)->visible());
   EXPECT_TRUE(menu->GetMenuItemByID(IDC_BOOKMARK_BAR_SHOW_MANAGED_BOOKMARKS)
                   ->visible());
 }