Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Side by Side Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm

Issue 2809003002: Making bookmark folder context menu display the number of bookmarks that will be opened by Open All (Closed)
Patch Set: Fixing compilation issues Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.h" 5 #import "chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.h"
6 6
7 #import "base/mac/foundation_util.h" 7 #import "base/mac/foundation_util.h"
8 #include "base/metrics/user_metrics.h" 8 #include "base/metrics/user_metrics.h"
9 #include "base/strings/sys_string_conversions.h" 9 #include "base/strings/sys_string_conversions.h"
10 #include "chrome/app/chrome_command_ids.h" // IDC_BOOKMARK_MENU 10 #include "chrome/app/chrome_command_ids.h" // IDC_BOOKMARK_MENU
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
113 113
114 Browser* browser = chrome::FindTabbedBrowser(bridge_->GetProfile(), true); 114 Browser* browser = chrome::FindTabbedBrowser(bridge_->GetProfile(), true);
115 if (!browser) { 115 if (!browser) {
116 browser = new Browser(Browser::CreateParams(bridge_->GetProfile(), true)); 116 browser = new Browser(Browser::CreateParams(bridge_->GetProfile(), true));
117 } 117 }
118 DCHECK(browser); 118 DCHECK(browser);
119 119
120 if (!node || !browser) 120 if (!node || !browser)
121 return; // shouldn't be reached 121 return; // shouldn't be reached
122 122
123 chrome::OpenAll(NULL, browser, node, disposition, browser->profile()); 123 chrome::OpenAll(nullptr, browser, node, disposition, browser->profile());
124 124
125 if (disposition == WindowOpenDisposition::NEW_FOREGROUND_TAB) { 125 if (disposition == WindowOpenDisposition::NEW_FOREGROUND_TAB) {
126 base::RecordAction(UserMetricsAction("OpenAllBookmarks")); 126 base::RecordAction(UserMetricsAction("OpenAllBookmarks"));
127 } else if (disposition == WindowOpenDisposition::NEW_WINDOW) { 127 } else if (disposition == WindowOpenDisposition::NEW_WINDOW) {
128 base::RecordAction(UserMetricsAction("OpenAllBookmarksNewWindow")); 128 base::RecordAction(UserMetricsAction("OpenAllBookmarksNewWindow"));
129 } else { 129 } else {
130 base::RecordAction(UserMetricsAction("OpenAllBookmarksIncognitoWindow")); 130 base::RecordAction(UserMetricsAction("OpenAllBookmarksIncognitoWindow"));
131 } 131 }
132 } 132 }
133 133
(...skipping 17 matching lines...) Expand all
151 WindowOpenDisposition disposition = WindowOpenDisposition::NEW_WINDOW; 151 WindowOpenDisposition disposition = WindowOpenDisposition::NEW_WINDOW;
152 [self openAll:[sender tag] withDisposition:disposition]; 152 [self openAll:[sender tag] withDisposition:disposition];
153 } 153 }
154 154
155 - (IBAction)openAllBookmarksIncognitoWindow:(id)sender { 155 - (IBAction)openAllBookmarksIncognitoWindow:(id)sender {
156 WindowOpenDisposition disposition = WindowOpenDisposition::OFF_THE_RECORD; 156 WindowOpenDisposition disposition = WindowOpenDisposition::OFF_THE_RECORD;
157 [self openAll:[sender tag] withDisposition:disposition]; 157 [self openAll:[sender tag] withDisposition:disposition];
158 } 158 }
159 159
160 @end // BookmarkMenuCocoaController 160 @end // BookmarkMenuCocoaController
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698