Keeping track of whether WebKit is in the callstack using RenderThread doesn'...

chrome/common/child_process.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/child_process.h"
 
 #include "base/basictypes.h"
 #include "base/string_util.h"
 #include "chrome/common/child_thread.h"
 
@@ skipping 14 matching lines @@
 
   // Signal this event before destroying the child process.  That way all
   // background threads can cleanup.
   // For example, in the renderer the RenderThread instances will be able to
   // notice shutdown before the render process begins waiting for them to exit.
   shutdown_event_.Signal();
 
   if (child_thread_.get())
     child_thread_->Stop();
 
-  // Make sure the child thread goes away first before setting child_process_ to
-  // NULL since it can use it.
-  child_thread_.reset();

[darin (slow to review), 2009/02/24 22:11:43]

can you explain why this change is made?

-
   child_process_ = NULL;
 }
 
 // Called on any thread
 void ChildProcess::AddRefProcess() {
   base::AtomicRefCountInc(&ref_count_);
 }
 
 // Called on any thread
 void ChildProcess::ReleaseProcess() {
@@ skipping 12 matching lines @@
 bool ChildProcess::ProcessRefCountIsZero() {
   return base::AtomicRefCountIsZero(&ref_count_);
 }
 
 void ChildProcess::OnFinalRelease() {
   if (child_thread_.get()) {
     child_thread_->owner_loop()->PostTask(
         FROM_HERE, new MessageLoop::QuitTask());
   }
 }