ui/file_manager/zip_archiver/BUILD.gn - Issue 2808993003: Build ZIP archiver in ui/file_manager.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/file_manager/zip_archiver/BUILD.gn

Issue 2808993003: Build ZIP archiver in ui/file_manager. (Closed)

Patch Set: Build ZIP archiver. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 # Copyright 2017 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 import("//build/config/features.gni")

	6

	7 if (enable_nacl) {
	hashimoto 2017/04/12 10:45:37 Shouldn't this check be performed at a more upper Shouldn't this check be performed at a more upper level (e.g. excluding zip_archiver entirely wnen enable_nacl==false)? Please make sure that you can build even when enable_nacl=false. takise 2017/04/13 00:49:47 Done. Show quoted text On 2017/04/12 10:45:37, hashimoto wrote: > Shouldn't this check be performed at a more upper level (e.g. excluding > zip_archiver entirely wnen enable_nacl==false)? > Please make sure that you can build even when enable_nacl=false. Done.
	8 copy("zip_archiver") {

	9 pexe_dir = get_label_info(

	10 "//ui/file_manager/zip_archiver/zip_archiver/cpp:zip_archiver_pnacl(//bu ild/toolchain/nacl:newlib_pnacl)",

	11 "root_out_dir")

	12

	13 sources = [

	14 "$pexe_dir/zip_archiver_pnacl.pexe",

	15 ]

	16

	17 outputs = [

	18 "$root_gen_dir/ui/file_manager/{{source_file_part}}.js",

	19 ]

	20

	21 deps = [

	22 "//ui/file_manager/zip_archiver/cpp:zip_archiver_pnacl",

	23 ]

	24 }

	25 }

OLD	NEW