Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 2808953003: Revert "Fix updating packages map on reload and add a regression test" (Closed)

Created:
3 years, 8 months ago by Cutch
Modified:
3 years, 8 months ago
Reviewers:
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Fix updating packages map on reload and add a regression test" This reverts commit 7a2d67f3baf80eea0ceddf70aea67e5298397117. BUG= Committed: https://github.com/dart-lang/sdk/commit/94df115e4bf9d6f724c81582a9c332bbc3da4942

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -33 lines) Patch
M runtime/bin/isolate_data.h View 1 chunk +0 lines, -8 lines 0 comments Download
M runtime/bin/loader.cc View 1 chunk +1 line, -9 lines 0 comments Download
M runtime/bin/vmservice/loader.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 1 chunk +1 line, -5 lines 0 comments Download
D runtime/observatory/tests/service/complex_reload/v2/.gitignore View 1 chunk +0 lines, -1 line 0 comments Download
D runtime/observatory/tests/service/complex_reload/v2/foobar_lib/foo.dart View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/service/complex_reload/v2/main.dart View 1 chunk +1 line, -3 lines 0 comments Download
D runtime/observatory/tests/service/complex_reload/v2/packages View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/service/complex_reload_test.dart View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Cutch
3 years, 8 months ago (2017-04-10 19:30:45 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
94df115e4bf9d6f724c81582a9c332bbc3da4942 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698