Issue 280883003: Fix FlooringDivByPowerOf2I on ARM/ARM64

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 280883003: Fix FlooringDivByPowerOf2I on ARM/ARM64 (Closed)

Created:
6 years, 7 months ago by m.m.capewell

Modified:
6 years, 7 months ago

Reviewers:
ulan, jochen (gone - plz use gerrit)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix FlooringDivByPowerOf2I on ARM/ARM64 Fix for divisor=1, found during code inspection. We can't hit this bug, due to HDiv::Canonicalize() discarding the operation, but it might avoid a future bug hunt. Patch also includes a small tidying of the ARM64 code. BUG= R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21313

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -10 lines)			Patch
	M	src/arm/lithium-codegen-arm.cc	View		1 chunk	+6 lines, -1 line	0 comments	Download
	M	src/arm64/lithium-codegen-arm64.cc	View		2 chunks	+8 lines, -9 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

m.m.capewell

6 years, 7 months ago (2014-05-14 14:34:46 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r21313 (presubmit successful).

Expand Messages | Collapse Messages